Fix couple of problems revealed by non-gcc compiler #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCC compiler for e2k architecture currently has no support for C++11 exceptions extensions. This patch is future compatible, since newer compiler releases will have such support.
According to the official gcc documentation[1] in order to use OpenMP one must specify -fopenmp flag. It is wrong to link with internal compiler library like -lgomp. This breaks other compilers like lcc. Note that special care for clang is not needed in case -fopenmp is used as described above. Furthermore cmake provides standard FindOpenMP.cmake module, so in order to check for OpenMP it is sufficient to use find_package(openmp). [1] https://gcc.gnu.org/onlinedocs/libgomp/Enabling-OpenMP.html
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change checks for lcc compiler and its version and disables not yet supported C++ features the same way as for ARMEL.
Second change fixes OpenMP detection to use standard cmake find_package(openmp).