New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching exclude tagged tests by Build Valiants is not working #97

Closed
kikuchy opened this Issue Jun 13, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@kikuchy

kikuchy commented Jun 13, 2018

Request

Please use FiltersExtension (and TagsExtension) instances individually for each Build Valiants (tasks).

Maybe same Extension instance is used for each other tasks on version 1.0.32.
https://github.com/mannodermaus/android-junit5/blob/master/android-junit5/src/main/kotlin/de/mannodermaus/gradle/plugins/junit5/tasks/UnitTest.kt#L105

I want to do

I want to switch exclude tagged tests statement by Android project's Build Valiants like this.

    testOptions {
        unitTests.all { task ->
            if (task.name.toLowerCase().contains("debug")) {
                junitPlatform {
                    filters {
                        tags {
                            exclude 'Slow'
                        }
                    }
                }
            }
        }
    }

I expect excluding @Tag("Slow") tagged tests only at debug build (testDebugUnitTest task), but it excludes at release build (testReleaseUnitTest task) too.

@mannodermaus mannodermaus added this to the 1.2.0 milestone Jun 23, 2018

@mannodermaus mannodermaus self-assigned this Jun 23, 2018

@mannodermaus

This comment has been minimized.

Owner

mannodermaus commented Jun 23, 2018

This is a reasonable request, which is why I'm putting this on the roadmap for the 1.2.0 release of the library. I'll keep you posted about the progress, and will leave a note once you can test this out using a snapshot!

@mannodermaus

This comment has been minimized.

Owner

mannodermaus commented Jul 7, 2018

Quick update: I've released the first 1.2.0-SNAPSHOT with support for build-variant aware filters. Please check the description on the PR for info on the DSL to use. Let me know if it works OK!

@kikuchy

This comment has been minimized.

kikuchy commented Jul 9, 2018

Thank you very much, it works perfectly at latest 1.2.0-SNAPSHOT !

I'm looking forward to releasing stable version with support for build-variant aware filters!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment