Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MKL for a faster DDtheta test run #221

Open
manodeep opened this issue Jun 10, 2020 · 1 comment
Open

Add MKL for a faster DDtheta test run #221

manodeep opened this issue Jun 10, 2020 · 1 comment

Comments

@manodeep
Copy link
Owner

Is your feature request related to a problem? Please describe.
Running the tests DDtheta_mocks always take a long time because there are no vectorized acos functions available directly through gcc/clang.

Describe the solution you'd like
A clear and concise description of what you want to happen.
icc has an implementation through MKL/SVML, and would be good to i) either install MKL as a dependency (with an option to disable) or ii) check if MKL is already available.

Then during compile time, if MKL is available, we should just use the vectorised MKL trig routines - will speed up the DDtheta_mocks runs significantly.

Describe alternatives you've considered
Compile directly with icc, if available.

The MKL linking code already exists in common.mk, so might not be too difficult to sort out

@manodeep
Copy link
Owner Author

Noting that the intel channel on conda has an mkl-devel package, that contains the relevant mkl.h header and the libraries. We could add an option to request MKL and expand out the inverse cosine into the MKL-defined functions + the existing fallback when neither icc nor MKL are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant