Fix convert endian bug #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't actually update the variable
|
Hello @Christopher-Bradshaw! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-07-31 01:12:28 UTC |
Repository owner
deleted a comment
Jul 31, 2019
Repository owner
deleted a comment
Jul 31, 2019
Repository owner
deleted a comment from
Christopher-Bradshaw
Jul 31, 2019
|
Thanks a lot for the fix! (Not sure why the notifications says I deleted comments...seems strange) |
|
@manodeep I think codacy-bot deletes its comments when you fix the things. And I'm guessing you gave it a key registered to you so github thinks it looks like you? Bit odd though... Anyway, thanks for the merge, will confirm that it works now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #190 for context.
Let me know if there is anything else to do here. I think it should be good to go, but will check back in later to make sure tests passed.