Skip to content

Conversation

@manodeep
Copy link
Owner

@manodeep manodeep commented Feb 8, 2020

Fixing #214

@manodeep manodeep added this to the v2.3.4 milestone Feb 8, 2020
@manodeep manodeep requested a review from lgarrison February 10, 2020 01:07
@manodeep
Copy link
Owner Author

manodeep commented Feb 10, 2020

Explanation from @1313e as to why installing in editable mode is necessary on TRAVIS:

The reason for it is that on Travis CI (specifically on Linux), the working directory is set to the root of the package. If you install it the normal way and then try to import it, the local package takes priority over the installed package (see my notes on how Python imports work from last year). As you haven't built that, it cannot find any files and crashes.

For further reference on how imports work in python, see here

Copy link
Collaborator

@lgarrison lgarrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only real question is the extra CHANGES.rst entry

@manodeep manodeep merged commit cb1ef57 into master Feb 12, 2020
@manodeep manodeep deleted the fix_py2 branch June 7, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants