Skip to content

Conversation

@lgarrison
Copy link
Collaborator

As discussed in #244 and #245. The runtime check is called from __init__.py, which avoids having to put the check inside each Python module.

I tested this at NERSC and it works as expected, with and without the hugepages module loaded.

@lgarrison lgarrison requested a review from manodeep April 15, 2021 15:23
@pep8speaks
Copy link

pep8speaks commented Apr 15, 2021

Hello @lgarrison! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-15 21:54:32 UTC

@lgarrison
Copy link
Collaborator Author

@manodeep Looks like some unrelated build failures, any idea what changed?

@manodeep
Copy link
Owner

Ahh yes - GH replaced their default pre-installed tools and some combinations of OS + compiler now fail. They apparently update the list of tools ~weekly, with the latest list of tools listed here. From what I can see:

  • 16.04 has gcc-5, gcc-9, clang-9
  • 18.04 has gcc-7, gcc-9, gcc-10, clang-9
  • 20.04 has gcc-9, gcc-10, clang-9, clang-10, clang-11
  • macos-latest (10.15) has gcc-8, gcc-9, gcc-10 (through brew), clang-12 (default clang), clang-11

Are you okay to fix these build failures?

@manodeep
Copy link
Owner

@lgarrison Should the astropy-bot have run on this PR?

@lgarrison
Copy link
Collaborator Author

Yeah, no sign of Astropy bot yet. Thanks for linking the docs, I should be good to fix the failures, fingers crossed!

@lgarrison lgarrison added this to the v2.4.0 milestone Apr 15, 2021
@lgarrison
Copy link
Collaborator Author

@manodeep Tests are passing, okay to merge?

@manodeep manodeep merged commit 868b622 into master Apr 17, 2021
@manodeep
Copy link
Owner

Yup - done now :)

Do you want to delete the branch?

@lgarrison lgarrison deleted the runtime-env-check branch April 17, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants