Skip to content

Conversation

@lgarrison
Copy link
Collaborator

Also update test instructions on RTD. From #288.

@lgarrison lgarrison added the docs label Mar 10, 2023
@lgarrison lgarrison requested a review from manodeep March 10, 2023 16:15
@lgarrison
Copy link
Collaborator Author

@manodeep Looks like the MacOS jobs are failing, unrelated to this PR. Maybe the macos-latest image got updated and broke something. Could you take a look?

The `npairs_found` variables needed to be protected under the conditional compilation flag `COUNT_VECTORIZED`. (This is not exposed to the user)
@manodeep
Copy link
Owner

@lgarrison Looks good to me. Just had one comment about using our favoured python -m pip rather than pip directly.

Semi-related, I did not get any email notification for the build failure. Did you?

@lgarrison
Copy link
Collaborator Author

Yes, I did get the emails, I guess only the PR author gets them. Thanks for the OSX fix; I'll merge as soon as the tests pass!

@lgarrison lgarrison merged commit 08068c0 into master Mar 11, 2023
@lgarrison lgarrison deleted the doc-fix-gh288 branch March 11, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants