-
Notifications
You must be signed in to change notification settings - Fork 57
Updated GitHub CI #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated GitHub CI #291
Conversation
|
Need to add Changelog. Not sure why the astropy bot is not running |
lgarrison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for taking the time to update this!
Minor question: what's the motivation behind testing both the 1.22 and 1.23 versions of Numpy? Was there a C API change?
|
Thanks @lgarrison. Nothing in particular, figured it would be better to test out the recent python and numpy versions - that's where I would expect things to break, if at all. |
|
@lgarrison Do we not have the astropy milestones checker bot anymore? |
|
I guess not. It looks like astropy has migrated to GH actions instead. E.g. for changelog checking: https://github.com/astropy/astropy/blob/main/.github/workflows/check_changelog.yml, with the bot living at https://github.com/pllim/actions-towncrier-changelog |
|
Fixed the conflict in the changelog. Looks like we would need to migrate to pyproject.toml before we can use towncrier and allied actions. That's beyond my knowledge - do you know how to do that? |
Trying to avoid duplicate runs
|
@lgarrison Okay to merge? |
|
Yep, LGTM! For |
Upgraded min python and numpy versions, and changed the compiler versions and the linux os's tested