Skip to content

Conversation

@manodeep
Copy link
Owner

Upgraded min python and numpy versions, and changed the compiler versions and the linux os's tested

@manodeep manodeep linked an issue May 10, 2023 that may be closed by this pull request
@manodeep manodeep requested a review from lgarrison May 10, 2023 04:44
@manodeep
Copy link
Owner Author

Need to add Changelog. Not sure why the astropy bot is not running

Copy link
Collaborator

@lgarrison lgarrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking the time to update this!

Minor question: what's the motivation behind testing both the 1.22 and 1.23 versions of Numpy? Was there a C API change?

@manodeep
Copy link
Owner Author

Thanks @lgarrison. Nothing in particular, figured it would be better to test out the recent python and numpy versions - that's where I would expect things to break, if at all.

@manodeep
Copy link
Owner Author

@lgarrison Do we not have the astropy milestones checker bot anymore?

@lgarrison
Copy link
Collaborator

I guess not. It looks like astropy has migrated to GH actions instead. E.g. for changelog checking: https://github.com/astropy/astropy/blob/main/.github/workflows/check_changelog.yml, with the bot living at https://github.com/pllim/actions-towncrier-changelog

@manodeep
Copy link
Owner Author

Fixed the conflict in the changelog.

Looks like we would need to migrate to pyproject.toml before we can use towncrier and allied actions. That's beyond my knowledge - do you know how to do that?

Trying to avoid duplicate runs
@manodeep
Copy link
Owner Author

@lgarrison Okay to merge?

@lgarrison
Copy link
Collaborator

Yep, LGTM!

For pyproject.toml, in theory it's not too hard to set up while still keeping most of the work in setup.py, but the Corrfunc build has enough quirks/customizations that it would need some careful testing before we deploy anything. But towncrier might not actually need a fully-fledged toml file; maybe it just needs the sections relevant to it?

@manodeep manodeep merged commit 0661e23 into master May 15, 2023
@manodeep manodeep deleted the update-ci-apr2023 branch May 15, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub CI runners need to be updated

3 participants