New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing and incorrect data units in HarddriveStorage and SanStorage getMaxTransferRate() #137

Closed
manoelcampos opened this Issue Jun 4, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@manoelcampos
Owner

manoelcampos commented Jun 4, 2018

Actual behavior

The HarddriveStorage.getMaxTransferRate() defines the disk transfer rate in Megabytes/sec.
The SanStorage overrides such a method by returning the minimum value
between themaxDataRate and the bandwidth. However, the last one is defined in Mbits/sec instead of Megabytes/sec. That makes the method return data in different units depending on if maxDataRate is lower than the bandwidth or not.

Megabytes/sec is the usual unit for disk transfer rate. However, since SanStorage extends HarddriveStorage, it's also confusing to have different units for the same method.

Expected behavior

maxDataRate and the bandwidth should be defined in Megabits/sec.
The default maxTransferRate for HarddriveStorage must also be converted to Megabits/sec.

If the issue is related to a specific method, provide a test case that fails in order to show the problem

New unit tests were added to both classes.

@manoelcampos manoelcampos added the bug label Jun 4, 2018

@manoelcampos manoelcampos self-assigned this Jun 4, 2018

@manoelcampos manoelcampos added this to the CloudSim Plus 3.0 milestone Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment