New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated GWT Widgets are not IsEditor #57

Open
masini opened this Issue Dec 23, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@masini

masini commented Dec 23, 2015

In GWT we have only the Editor framework which does a correct databinding between POJOs and Widgets.

I've tried with no success Errai Databinding, to simplistic for a complex interface.

Unfortunately generated widgets are Panels, and as such they don't implement IsEditor interface, which is what the Editor framework uses for integration between generated Autobeans and Wdgets.

I would like the generator to change how it works so that we obtain Widgets compatible with it.

In case I can contribute, but I need to know if you have any suggestions for this.

Thank you.

@knives85

This comment has been minimized.

Show comment
Hide comment
@knives85

knives85 Dec 23, 2015

I'm having a similar problem. I'm interested in any possible solution.

Thanks

knives85 commented Dec 23, 2015

I'm having a similar problem. I'm interested in any possible solution.

Thanks

@manolo

This comment has been minimized.

Show comment
Hide comment
@manolo

manolo Jan 13, 2016

Owner

What do you guys suggest for implementing IsEditor? not all polymer widgets are thought for storing values, and some of them could store more than a value.
A very simple solution could be consider only widgets having the getValue() method.
Could you write a bunch of examples of the widgets modified so as they work for you? for instance modify PaperInput, PaperSlider.
Another possibility is that you override each class with your own implementation. thoughts ?

Owner

manolo commented Jan 13, 2016

What do you guys suggest for implementing IsEditor? not all polymer widgets are thought for storing values, and some of them could store more than a value.
A very simple solution could be consider only widgets having the getValue() method.
Could you write a bunch of examples of the widgets modified so as they work for you? for instance modify PaperInput, PaperSlider.
Another possibility is that you override each class with your own implementation. thoughts ?

@masini

This comment has been minimized.

Show comment
Hide comment
@masini

masini Feb 3, 2016

Hi Manolo, I think that we can't really understand if a web-component is also an Editor and which kind of Editor.

May be the best way is a command-line switch where, during the generation phase, we can set the kind of Editor, may be an "IsEditor<ValueBoxEditor>" or a ListEditorWrapper.

What do you think ?

masini commented Feb 3, 2016

Hi Manolo, I think that we can't really understand if a web-component is also an Editor and which kind of Editor.

May be the best way is a command-line switch where, during the generation phase, we can set the kind of Editor, may be an "IsEditor<ValueBoxEditor>" or a ListEditorWrapper.

What do you think ?

@manolo manolo added the enhancement label Aug 23, 2016

@manolo

This comment has been minimized.

Show comment
Hide comment
@manolo

manolo Aug 23, 2016

Owner

We will discuss this for a future version, but not before we listen to community about the tendency on using Elements vs Widgets. It seems that GWT is encouraging the use of them instead of widgets, etc.

Owner

manolo commented Aug 23, 2016

We will discuss this for a future version, but not before we listen to community about the tendency on using Elements vs Widgets. It seems that GWT is encouraging the use of them instead of widgets, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment