error buildig under windows without make. #40

Closed
guyvernk opened this Issue Jun 17, 2012 · 5 comments

3 participants

@guyvernk

patch for rebar.config:

- {pre_hooks, [{compile, "escript write_compile_flags"}]}.

+ {pre_hooks, [{"(linux|bsd|darwin|solaris)", compile, "make include/compile_flags.hrl"},{"win32", compile, "escript write_compile_flags include/compile_flags.hrl"}]}.
@guyvernk

but generated include/compile_flags.hrl under windows empty

@dch

@kostis any chance of getting a fix for this issue committed? basically on Windows proper fails to build as the empty include/compile_flags.hrl cannot be generated with make. A number of the windows erlang applications are being shipped that don't require a unix make / shell environment to build.

@kostis
Collaborator

I do not have any access to a Windows machine and therefore I cannot test this. Can you please verify that the suggested patch works under windows and fixes the issue? If yes, I can pull it afterwards.

@dch

@kostis, yes tested but needs a minor modification. I've sent #51 that includes a working patch, many thanks to your colleagues for this excellent tool! @slowbro13 thanks for the original patch.

@kostis
Collaborator

Fixed by merging the #51 pull request.

@kostis kostis closed this Oct 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment