Skip to content

Indices fix #31

Closed
wants to merge 2 commits into from

3 participants

@yrashk
yrashk commented Apr 12, 2012

Reduces memory used by generator indices. Follow up to #19

Before the patch:

1> erts_debug:size(proper_types:vector(1000000,1)).
2000108

After the patch:

1> erts_debug:size(proper_types:vector(1000000,1)).
105

This makes sequence generation lazy, hence we don't waste memory if it is unnecessary.

Yurii Rashko... added some commits Oct 22, 2011
@kostis
Collaborator
kostis commented Apr 16, 2012

Just a quick question: Is this pull request independent of #19 or it needs to be merged with it?

(I mean, can spawngrid/proper@7859a50 be merged on its own?)

@yrashk
yrashk commented Apr 16, 2012

As it is, it is not independent. However the same problem exists in vanilla PropEr (just in a slightly different and less obvious form). However, since as you know I really want to get #19 merged in, I see no point in providing two patches for the same problem. I'd rather have it merged with #19 (besides, this pullreq contains the commit from #19 anyway)

@manopapad
Owner

Merged the equivalent #35

@manopapad manopapad closed this May 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.