Michael Anstis manstis

  • JBoss
  • England
  • Joined on

Organizations

@droolsjbpm
@manstis

@mswiderski nope.. unless you see anything different; i.e. WebLogic 12c does bundle org.apache.commons:commons-lang3 (I searched the installation f…

@manstis

@mswiderski OK. managed to install and found it only appears to contain commons-lang:commons-lang.

@manstis

@mswiderski Hi Maciejs, could you please verify WebLogic 12c doesn't have org.apache.commons:commons-lang3 bundled with it? I made the assumption i…

@manstis
  • @manstis fde87eb
    Upgrade to org.apache.commons:commons-lang3
@manstis
  • @manstis 987a553
    Upgrade to org.apache.commons:commons-lang3
@manstis
  • @manstis 54cd1bc
    Upgrade to org.apache.commons:commons-lang3
@manstis
  • @manstis 48cc42f
    Upgrade to org.apache.commons:commons-lang3
@manstis
  • @manstis 0e81009
    Upgrade to org.apache.commons:commons-lang3
manstis commented on pull request uberfire/uberfire#101
@manstis

Thanks Cristiano - you're now officially part of the team (this being your first commit!)

@manstis
manstis merged pull request uberfire/uberfire#101
@manstis
Fixed module name in comment
1 commit with 1 addition and 1 deletion
manstis commented on pull request droolsjbpm/kie-wb-common#19
@manstis

Still some formatting issues, but happy to resolve when merged; otherwise code looks ok. @Salaboy Are you to test this enhancement? Let me know whe…

manstis commented on pull request uberfire/uberfire-extensions#25
@manstis

Still some formatting issues, but happy to resolve when merged; otherwise code looks ok.

manstis pushed to master at manstis/grid
@manstis
manstis commented on pull request droolsjbpm/kie-wb-common#17
manstis closed pull request droolsjbpm/drools#429
@manstis
Guided decision trees - new test for testing of unmarshalling drls containing different line separators
manstis commented on pull request droolsjbpm/drools#429
@manstis
  • 532cd00
    DROOLS-761 Guided decision trees - new test for testing of unmarshall…
manstis commented on pull request droolsjbpm/kie-wb-common#17
@manstis

Looks OK to me - other than some formatting issues (but I can fix when merging). @Salaboy OK with you?

manstis commented on pull request uberfire/uberfire-extensions#24
@manstis

Looks OK to me - other than some formatting issues (but I can fix when merging). @Salaboy OK with you?

manstis pushed to master at manstis/grid
@manstis
  • @manstis 5b132fc
    Rendering fixes for merged cells.
manstis commented on pull request droolsjbpm/kie-wb-common#16
@manstis

Use of KIE's DefaultErrorCallback would be better.

manstis commented on pull request droolsjbpm/kie-wb-common#16
@manstis

More alerts!

manstis commented on pull request droolsjbpm/kie-wb-common#16
@manstis

Same here.. we don't really want Window.alerts(..) in the code!

manstis commented on pull request droolsjbpm/kie-wb-common#16
@manstis

I suspect this can be removed?

manstis commented on pull request droolsjbpm/kie-wb-common#16
@manstis

Should this be @PostConstruct instead of @AfterInitialization (which signals the Errai message bus is available)

manstis commented on pull request uberfire/uberfire-extensions#23
@manstis

Same as above.

manstis commented on pull request uberfire/uberfire-extensions#23
@manstis

Should this be "package" access level; private or protected may be more suitable.

manstis pushed to master at manstis/grid
@manstis
  • @manstis d981d4e
    Re-write of cell Grouping to support animation during collapse and ex…
manstis closed pull request droolsjbpm/drools#427
@manstis
DROOLS-759 GuidedDecisionTreeModelUnmarshallingVisitor doesn't support unmarshalling rules that contain line with only spaces in LHS