HTTP requests sent through Buddy without ; echo at the end cause a hang and the test does not complete.

[PavelShilin89]

Description:
HTTP requests sent through Buddy without ; echo at the end cause the request to hang indefinitely, and the test does not complete.

• The query works correctly when executed via MySQL CLI (mysql -h0 -P9306 -e "show version;").
• The issue occurs only when using HTTP requests through Buddy.

MRE

––– input –––
rm -f /var/log/manticore/searchd.log; searchd --stopwait > /dev/null; searchd; if timeout 10 grep -qm1 '\[BUDDY\] started' <(tail -n 1000 -f /var/log/manticore/searchd.log); then echo 'Buddy started!'; else echo 'Timeout or failed!'; cat /var/log/manticore/searchd.log;fi
––– output –––
Manticore %{SEMVER} %{COMMITDATE}#!/(\sdev)?\s/!#(columnar %{SEMVER} %{COMMITDATE}) (secondary %{SEMVER} %{COMMITDATE}) (knn %{SEMVER} %{COMMITDATE})
Copyright (c) 2001-2016, Andrew Aksyonoff
Copyright (c) 2008-2016, Sphinx Technologies Inc (http://sphinxsearch.com)
Copyright (c) 2017-%{YEAR}, Manticore Software LTD (https://manticoresearch.com)
[#!/[0-9]{2}:[0-9]{2}.[0-9]{3}/!#] [#!/[0-9]+/!#] using config file '/etc/manticoresearch/manticore.conf' (%{NUMBER} chars)...
starting daemon version '%{SEMVER} %{COMMITDATE}#!/(\sdev)?\s/!#(columnar %{SEMVER} %{COMMITDATE}) (secondary %{SEMVER} %{COMMITDATE}) (knn %{SEMVER} %{COMMITDATE})' ...
listening on %{IPADDR}:9312 for sphinx and http(s)
listening on %{IPADDR}:9306 for mysql
listening on %{IPADDR}:9308 for sphinx and http(s)
Buddy started!
––– input –––
mysql -h0 -P9306 -e "show version;"
––– output –––
+-----------+----------------------------------+
| Component | Version                          |
+-----------+----------------------------------+
| Daemon    | 6.3.9 d76b94e71@25011415 dev     |
| Columnar  | columnar 2.3.1 9d9a466@24122408  |
| Secondary | secondary 2.3.1 9d9a466@24122408 |
| KNN       | knn 2.3.1 9d9a466@24122408       |
| Buddy     | buddy v3.0.1                     |
+-----------+----------------------------------+
––– input –––
curl "0:9308/sql?mode=raw" -d "show version;"; echo
––– output –––
[{"total":5,"error":"","warning":"","columns":[{"Component":{"type":"string"}},{"Version":{"type":"string"}}],"data":[{"Component":"Daemon","Version":"6.3.9 d76b94e71@25011415 dev"},{"Component":"Columnar","Version":"columnar 2.3.1 9d9a466@24122408"},{"Component":"Secondary","Version":"secondary 2.3.1 9d9a466@24122408"},{"Component":"KNN","Version":"knn 2.3.1 9d9a466@24122408"},{"Component":"Buddy","Version":"buddy v3.0.1"}]}]
––– input –––
curl "0:9308/sql?mode=raw" -d "show version;"
––– output –––

[sanikolaev]

echo -n 123 should be enough to reproduce this issue in CLT

[donhardman]

Duplicate of #38

We are unable to detect command output because we read from PTY when no newline is provided, and it's impossible to fix on the CLT side. We should investigate the issue where the daemon loses newline symbols even when buddy sends them.

As a workaround I suggest to use alias for curl: #54