Skip to content

ci(workflows): update runner to ubuntu-24.04 and improve Linux build - #92

Merged
donhardman merged 13 commits into
masterfrom
fix/embeddings-linux-build
Jun 2, 2025
Merged

ci(workflows): update runner to ubuntu-24.04 and improve Linux build#92
donhardman merged 13 commits into
masterfrom
fix/embeddings-linux-build

Conversation

@donhardman

Copy link
Copy Markdown
Member
  • Upgrade GitHub Actions runners from ubuntu-22.04 to ubuntu-24.04 for embedding build and pack publish workflows
  • Add GitHub Container Registry login step for Linux builds to enable authenticated image access
  • Replace hardcoded Docker image with architecture-specific images for Linux build job
  • Remove redundant environment variables and streamline Docker build commands

- Upgrade GitHub Actions runners from ubuntu-22.04 to ubuntu-24.04 for embedding build and pack publish workflows
- Add GitHub Container Registry login step for Linux builds to enable authenticated image access
- Replace hardcoded Docker image with architecture-specific images for Linux build job
- Remove redundant environment variables and streamline Docker build commands
@CLAassistant

CLAassistant commented May 31, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

- Delete redundant login step for GHCR in embedding build workflow
- Simplify workflow by removing unnecessary Docker login for Linux distribution
@github-actions

github-actions Bot commented May 31, 2025

Copy link
Copy Markdown

Windows test results

  5 files    5 suites   15m 32s ⏱️
468 tests 451 ✅ 17 💤 0 ❌
476 runs  459 ✅ 17 💤 0 ❌

Results for commit 5548492.

♻️ This comment has been updated with latest results.

- Separate embedding_linux_pack into embedding_linux_amd_pack and embedding_linux_arm_pack
- Use ubuntu-24.04 runner for amd64 and ubuntu-24.04-arm runner for aarch64
- Update downstream jobs to depend on both new architecture-specific jobs
- Improve build matrix clarity and runner specificity for linux embeddings
- Consolidate separate embedding build jobs into a single matrix-based job
- Simplify runner selection logic based on distro and architecture inputs
- Add GitHub Container Registry login step for Linux builds
- Update downstream job dependencies to use the unified embedding build job
- Remove GitHub Container Registry login from embedding build workflow
- Simplify workflow since GHCR login is no longer required for builds
- Add additional search paths for embeddings library in build and source dirs
- Replace strip-based Build ID fix with setting proper permissions on Linux
- Disable automatic shared library dependency detection in DEB packaging
- Set correct package architecture for aarch64 and x86_64 in DEB config
- Make post-install script more robust by ignoring chmod errors on embeddings lib
- Ensure embeddings component is optional to avoid packaging issues
- Add special handling in CMakeLists.txt to install ARM64 embeddings library as a regular file to avoid Build ID problems
- Implement multiple fallback methods (strip, objcopy) for adding Build ID on non-ARM64 Linux builds
- Update DEB packaging to fully disable dependency scanning and Build ID checks to prevent related packaging errors
- Introduce a fake objdump wrapper script for ARM64 to bypass Build ID detection during packaging
- Detect ARM64/aarch64 architecture and apply alternative installation method
- Add fake objdump script to bypass Build ID detection on ARM64
- Use objcopy to remove Build ID section from embeddings library on ARM64
- Retain original strip and patchelf processing for non-ARM64 systems
- Ensure processed library is used for installation to fix Build ID undefined issue on Debian ARM64
@donhardman
donhardman requested review from glookka and sanikolaev May 31, 2025 10:43
@donhardman donhardman mentioned this pull request May 31, 2025
6 tasks
- Replace CentOS 7 based images with newer glibc 2.28 and OpenSSL 1.1.1k versions
- Align build environment with RHEL 8+ to deprecate CentOS 7 support
- Clean up test.yml by deleting unnecessary runner entries
- Prevent potential conflicts after embedding build template refactor
@github-actions

github-actions Bot commented Jun 2, 2025

Copy link
Copy Markdown

Linux debug test results

  8 files    8 suites   11m 17s ⏱️
485 tests 468 ✅ 17 💤 0 ❌
499 runs  482 ✅ 17 💤 0 ❌

Results for commit 5548492.

@github-actions

github-actions Bot commented Jun 2, 2025

Copy link
Copy Markdown

Linux release test results

  8 files    8 suites   6m 23s ⏱️
485 tests 468 ✅ 17 💤 0 ❌
499 runs  482 ✅ 17 💤 0 ❌

Results for commit 5548492.

@donhardman
donhardman merged commit c91e98c into master Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants