Fix issue while fuzzy=0 may lead to escaped operators#536
Merged
Conversation
clt❌ CLT tests in test/clt-tests/core/test-writing-binlog-during-parallel-queries.rec––– input –––
set -b +m; sed -i '/data_dir = \/var\/lib\/manticore/a\ binlog_common = 1\n' /etc/manticoresearch/manticore.conf
––– output –––
OK
––– input –––
for i in {1..10}; do rm -f /var/log/manticore/searchd.log; stdbuf -oL searchd --stopwait > /dev/null; stdbuf -oL searchd > /dev/null; if timeout 10 grep -qm1 'accepting connections' <(tail -n 1000 -f /var/log/manticore/searchd.log); then echo 'Accepting connections!'; else echo 'Timeout or failed!'; fi; mysql -P9306 -h0 -e "drop table if exists t1"; mysql -P9306 -h0 -e "drop table if exists t2"; for n in 1 2; do mysql -P9306 -h0 -e "create table t${n}"; done; sleep 1; for n in 1 2; do mysql -P9306 -h0 -e "insert into t${n} values(0)" &>/dev/null; done; wait 5>/dev/null 2>&1; echo $?; mysql -P9306 -h0 -e "show tables; select * from t1; select * from t2;"; mysql -P9306 -h0 -e "flush logs"; done
––– output –––
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
- | id |
+ | id |
- +---------------------+
+ +--------------------+
- +---------------------+
+ +--------------------+
|
7dafb55 to
d44a937
Compare
clt❌ CLT tests in test/clt-tests/replication/test-replication-with-mysqldump.rec––– input –––
export INSTANCE=1
––– output –––
OK
––– input –––
mkdir -p /var/{run,lib,log}/manticore-${INSTANCE}
––– output –––
OK
––– input –––
stdbuf -oL searchd -c test/clt-tests/base/searchd-with-flexible-ports.conf > /dev/null
––– output –––
OK
––– input –––
if timeout 10 grep -qm1 '\[BUDDY\] started' <(tail -n 1000 -f /var/log/manticore-${INSTANCE}/searchd.log); then echo 'Buddy started!'; else echo 'Timeout or failed!'; cat /var/log/manticore-${INSTANCE}/searchd.log; fi
––– output –––
OK
––– input –––
export INSTANCE=2
––– output –––
OK
––– input –––
mkdir -p /var/{run,lib,log}/manticore-${INSTANCE}
––– output –––
OK
––– input –––
stdbuf -oL searchd -c test/clt-tests/base/searchd-with-flexible-ports.conf > /dev/null
––– output –––
OK
––– input –––
if timeout 10 grep -qm1 '\[BUDDY\] started' <(tail -n 1000 -f /var/log/manticore-${INSTANCE}/searchd.log); then echo 'Buddy started!'; else echo 'Timeout or failed!'; cat /var/log/manticore-${INSTANCE}/searchd.log; fi
––– output –––
OK
––– input –––
export INSTANCE=3
––– output –––
OK
––– input –––
mkdir -p /var/{run,lib,log}/manticore-${INSTANCE}
––– output –––
OK
––– input –––
stdbuf -oL searchd -c test/clt-tests/base/searchd-with-flexible-ports.conf > /dev/null
––– output –––
OK
––– input –––
if timeout 10 grep -qm1 '\[BUDDY\] started' <(tail -n 1000 -f /var/log/manticore-${INSTANCE}/searchd.log); then echo 'Buddy started!'; else echo 'Timeout or failed!'; cat /var/log/manticore-${INSTANCE}/searchd.log; fi
––– output –––
OK
––– input –––
export CLUSTER_NAME=c
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "create cluster ${CLUSTER_NAME}"
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "show status like 'cluster_${CLUSTER_NAME}_status'\G"
––– output –––
OK
––– input –––
echo 'the, and, of' > /tmp/stopwords.txt
––– output –––
OK
––– input –––
echo 'cat => feline' > /tmp/exceptions.txt
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "CREATE TABLE tbl1 (id BIGINT, f TEXT, a INT, b FLOAT, j JSON, m MULTI, s STRING, e BOOL, d TIMESTAMP, v MULTI64, fv FLOAT_VECTOR KNN_TYPE='hnsw' KNN_DIMS='4' HNSW_SIMILARITY='l2') ENGINE='columnar' morphology='stem_en' stopwords='/tmp/stopwords.txt' exceptions='/tmp/exceptions.txt' rt_mem_limit='256M';"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "SHOW TABLE tbl1 SETTINGS\G;"
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "INSERT INTO tbl1 VALUES (1, 'The cat runs', 42, 3.14, '{\"key\":\"value\"}', (1,2,3), 'test', 1, '2024-12-16 12:00:00', (123456789012345678, 987654321098765432), (0.1, 0.2, 0.3, 0.4));"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "ALTER CLUSTER c ADD tbl1;"
––– output –––
OK
––– input –––
for n in `seq 2 $INSTANCE`; do mysql -h0 -P${n}306 -e "join cluster ${CLUSTER_NAME} at '127.0.0.1:1312'"; done;
––– output –––
OK
––– input –––
mysql -h0 -P${INSTANCE}306 -e "show status like 'cluster_${CLUSTER_NAME}_status'\G"
––– output –––
OK
––– input –––
echo '=> faster' > /tmp/wordforms.txt
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "CREATE TABLE tbl2 (id BIGINT, f TEXT, a INT, b FLOAT, j JSON, m MULTI, s STRING, e BOOL, d TIMESTAMP, v MULTI64, fv FLOAT_VECTOR KNN_TYPE='hnsw' KNN_DIMS='4' HNSW_SIMILARITY='l2') ENGINE='rowwise' morphology='stem_ru' wordforms='/tmp/wordforms.txt' rt_mem_limit='512M';"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "SHOW TABLE tbl2 SETTINGS\G;"
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "INSERT INTO tbl2 VALUES (1, 'Текст на русском', 84, 2.71, '{\"ключ\":\"значение\"}', (4,5,6), 'строка', 0, '2023-11-15 08:30:00', (987654321098765432, 123456789012345678), (0.4, 0.3, 0.2, 0.1));"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "INSERT INTO tbl2 VALUES (2, 'Прыжок', 19, 1.62, '{\"движение\":\"прыжок\",\"число\":3}', (7,8,9), 'пример', 1, '2024-06-10 15:45:00', (345678901234567890, 567890123456789012), (0.8, 0.7, 0.6, 0.5));"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "ALTER CLUSTER c ADD tbl2;"
––– output –––
OK
––– input –––
mysql -h0 -P3306 -e "CREATE TABLE tbl3 (id BIGINT, f TEXT, a INT, b FLOAT, j JSON, m MULTI, s STRING, e BOOL, d TIMESTAMP, v MULTI64, fv FLOAT_VECTOR KNN_TYPE='hnsw' KNN_DIMS='4' HNSW_SIMILARITY='l2') ENGINE='rowwise' rt_mem_limit='512M';"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P3306 -e "SHOW TABLE tbl3 SETTINGS\G;"
––– output –––
OK
––– input –––
mysql -h0 -P3306 -e "INSERT INTO tbl3 (id, f, a, b, j, m, s, e, d, v, fv) VALUES (1, 'Plain example', 42, 3.14, '{\"key\":\"value\"}', (1,2,3), 'plain_string', 1, '2024-12-16 12:00:00', (123456789012345678, 987654321098765432), (0.1, 0.2, 0.3, 0.4));"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P3306 -e "ALTER CLUSTER c ADD tbl3;"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "SHOW STATUS LIKE 'cluster_c_indexes';"
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl1 on port $port:"; mysql -h0 -P$port -e "SELECT * FROM c:tbl1 ORDER BY id ASC;"; done
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl2 on port $port:"; mysql -h0 -P$port -e "SELECT * FROM c:tbl2 ORDER BY id ASC;"; done
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl3 on port $port:"; mysql -h0 -P$port -e "SELECT * FROM c:tbl3 ORDER BY id ASC;"; done
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "REPLACE INTO c:tbl1 VALUES (1, 'Updated feline runs', 42, 3.14, '{\"key\":\"updated\"}', (1,2,3), 'test', 1, '2024-12-16 12:00:00', (123456789012345678, 987654321098765432), (0.1, 0.2, 0.3, 0.4));"; echo $?
––– output –––
OK
––– input –––
mysqldump -etc --column-statistics=0 --replace -u cluster -h0 -P1306 --skip-comments manticore c:tbl1 | mysql -h0 -P1306; echo $?
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl1 on port $port:"; mysql -h0 -P$port -e "SELECT * FROM c:tbl1 ORDER BY id ASC;"; done
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do mysql -h0 -P$port -e "SET GLOBAL cluster_user = 'new_username';"; done
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do timeout 10 bash -c "while ! mysql -h0 -P$port -e \"SHOW VARIABLES LIKE 'cluster_user';\" | grep -q '| cluster_user | new_username |'; do sleep 1; done" && echo "Port $port: cluster_user is new_username." || { echo "Port $port: cluster_user is not new_username."; exit 1; }; done
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "DELETE FROM c:tbl2 WHERE id = 2;"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P3306 -e "INSERT INTO c:tbl3 (id, f, a, b, j, m, s, e, d, v, fv) VALUES (2, 'New plain entry', 50, 5.5, '{\"new\":\"entry\"}', (10,11,12), 'new_string', 0, '2025-03-02 10:00:00', (111222333444555666, 777888999000111222), (0.6, 0.7, 0.8, 0.9));"; echo $?
––– output –––
- 0
+ ERROR 1064 (42000) at line 1: error at PostRollback, code 3 (transaction aborted, server can continue), seqno 7
+ 1
––– input –––
mysqldump -etc --column-statistics=0 --replace --net-buffer-length=16M -u new_username -h0 -P2306 --skip-comments manticore c:tbl1 c:tbl2 c:tbl3 | mysql -h0 -P3306; echo $?
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl1 on port $port:"; mysql -h0 -P$port -e "SELECT * FROM c:tbl1 ORDER BY id ASC;"; done
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl2 on port $port:"; mysql -h0 -P$port -e "SELECT * FROM c:tbl2 ORDER BY id ASC;"; done
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl3 on port $port:"; mysql -h0 -P$port -e "SELECT * FROM c:tbl3 ORDER BY id ASC;"; done
––– output –––
- +------+-----------------+------+----------+-----------------+----------+--------------+------+------+---------------------------------------+-------------------------------------+
+ +------+---------------+------+----------+-----------------+-------+--------------+------+------+---------------------------------------+-------------------------------------+
- | id | f | a | b | j | m | s | e | d | v | fv |
+ | id | f | a | b | j | m | s | e | d | v | fv |
- +------+-----------------+------+----------+-----------------+----------+--------------+------+------+---------------------------------------+-------------------------------------+
+ +------+---------------+------+----------+-----------------+-------+--------------+------+------+---------------------------------------+-------------------------------------+
- | 1 | Plain example | 42 | 3.140000 | {"key":"value"} | 1,2,3 | plain_string | 1 | 0 | 123456789012345678,987654321098765432 | 0.100000,0.200000,0.300000,0.400000 |
+ | 1 | Plain example | 42 | 3.140000 | {"key":"value"} | 1,2,3 | plain_string | 1 | 0 | 123456789012345678,987654321098765432 | 0.100000,0.200000,0.300000,0.400000 |
- | 2 | New plain entry | 50 | 5.500000 | {"new":"entry"} | 10,11,12 | new_string | 0 | 0 | 111222333444555666,777888999000111222 | 0.600000,0.700000,0.800000,0.900000 |
+ +------+---------------+------+----------+-----------------+-------+--------------+------+------+---------------------------------------+-------------------------------------+
- +------+-----------------+------+----------+-----------------+----------+--------------+------+------+---------------------------------------+-------------------------------------+
+ Data from c:tbl3 on port 2306:
- Data from c:tbl3 on port 2306:
+ +------+---------------+------+----------+-----------------+-------+--------------+------+------+---------------------------------------+-------------------------------------+
- +------+-----------------+------+----------+-----------------+----------+--------------+------+------+---------------------------------------+-------------------------------------+
+ | id | f | a | b | j | m | s | e | d | v | fv |
- | id | f | a | b | j | m | s | e | d | v | fv |
+ +------+---------------+------+----------+-----------------+-------+--------------+------+------+---------------------------------------+-------------------------------------+
- +------+-----------------+------+----------+-----------------+----------+--------------+------+------+---------------------------------------+-------------------------------------+
+ | 1 | Plain example | 42 | 3.140000 | {"key":"value"} | 1,2,3 | plain_string | 1 | 0 | 123456789012345678,987654321098765432 | 0.100000,0.200000,0.300000,0.400000 |
- | 1 | Plain example | 42 | 3.140000 | {"key":"value"} | 1,2,3 | plain_string | 1 | 0 | 123456789012345678,987654321098765432 | 0.100000,0.200000,0.300000,0.400000 |
+ +------+---------------+------+----------+-----------------+-------+--------------+------+------+---------------------------------------+-------------------------------------+
- | 2 | New plain entry | 50 | 5.500000 | {"new":"entry"} | 10,11,12 | new_string | 0 | 0 | 111222333444555666,777888999000111222 | 0.600000,0.700000,0.800000,0.900000 |
+ Data from c:tbl3 on port 3306:
- +------+-----------------+------+----------+-----------------+----------+--------------+------+------+---------------------------------------+-------------------------------------+
+ +------+---------------+------+----------+-----------------+-------+--------------+------+------+---------------------------------------+-------------------------------------+
- Data from c:tbl3 on port 3306:
+ | id | f | a | b | j | m | s | e | d | v | fv |
- +------+-----------------+------+----------+-----------------+----------+--------------+------+------+---------------------------------------+-------------------------------------+
+ +------+---------------+------+----------+-----------------+-------+--------------+------+------+---------------------------------------+-------------------------------------+
- | id | f | a | b | j | m | s | e | d | v | fv |
+ | 1 | Plain example | 42 | 3.140000 | {"key":"value"} | 1,2,3 | plain_string | 1 | 0 | 123456789012345678,987654321098765432 | 0.100000,0.200000,0.300000,0.400000 |
- +------+-----------------+------+----------+-----------------+----------+--------------+------+------+---------------------------------------+-------------------------------------+
+ +------+---------------+------+----------+-----------------+-------+--------------+------+------+---------------------------------------+-------------------------------------+
- | 1 | Plain example | 42 | 3.140000 | {"key":"value"} | 1,2,3 | plain_string | 1 | 0 | 123456789012345678,987654321098765432 | 0.100000,0.200000,0.300000,0.400000 |
- | 2 | New plain entry | 50 | 5.500000 | {"new":"entry"} | 10,11,12 | new_string | 0 | 0 | 111222333444555666,777888999000111222 | 0.600000,0.700000,0.800000,0.900000 |
- +------+-----------------+------+----------+-----------------+----------+--------------+------+------+---------------------------------------+-------------------------------------+
––– input –––
mysql -h0 -P1306 -e "ALTER CLUSTER c DROP tbl1;"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "SHOW STATUS LIKE 'cluster_c_indexes';"
––– output –––
OK
––– input –––
echo 'new, stop, words' > /tmp/new_stopwords.txt; echo $?
––– output –––
OK
––– input –––
echo 'dog => canine' > /tmp/new_exceptions.txt; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "ALTER TABLE tbl1 stopwords='/tmp/new_stopwords.txt' exceptions='/tmp/new_exceptions.txt';"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "SHOW TABLE tbl1 SETTINGS\G;"
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "REPLACE INTO tbl1 VALUES (1, 'Updated feline runs', 42, 3.14, '{\"key\":\"updated\"}', (1,2,3), 'test', 1, '2024-12-16 12:00:00', (123456789012345678, 987654321098765432), (0.1, 0.2, 0.3, 0.4));"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "ALTER CLUSTER c ADD tbl1;"; echo $?
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl1 on port $port:"; mysql -h0 -P$port -e "SELECT * FROM c:tbl1 ORDER BY id ASC;"; done
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "SHOW TABLE c:tbl1 SETTINGS\G;"
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl1 on port $port:"; mysql -h0 -P$port -e "SELECT id, f, HIGHLIGHT() FROM c:tbl1 WHERE MATCH('new runs');"; done
––– output –––
OK
––– input –––
mysql -h0 -P1306 -e "INSERT INTO c:tbl1 (id, f, a, b, j, m, s, e, d, v, fv) VALUES (2, 'The dog barks', 10, 2.5, '{\"animal\":\"dog\"}', (4,5), 'bark', 1, '2025-01-01 10:00:00', (111222333444555, 666777888999000), (0.5, 0.6, 0.7, 0.8));"; echo $?
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl1 on port $port:"; mysql -h0 -P$port -e "SELECT id, f, HIGHLIGHT() FROM c:tbl1 WHERE MATCH('canine');"; done
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl1 on port $port:"; mysql -h0 -P$port -e "SELECT * FROM c:tbl1 ORDER BY id ASC;"; done
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "ALTER CLUSTER c DROP tbl2;"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "SHOW STATUS LIKE 'cluster_c_indexes';"
––– output –––
OK
––– input –––
ls /usr/share/manticore/ru.pak
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "ALTER TABLE tbl2 morphology='lemmatize_ru';"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "SHOW TABLE tbl2 SETTINGS\G;"
––– output –––
OK
––– input –––
mysqldump -etc --column-statistics=0 --replace -u new_username -h0 -P2306 --skip-comments manticore tbl2 | mysql -P2306 -h0; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "ALTER CLUSTER c ADD tbl2;"; echo $?
––– output –––
OK
––– input –––
mysql -h0 -P2306 -e "INSERT INTO c:tbl2 (id, f, a, b, j, m, s, e, d, v, fv) VALUES (2, 'Кот прыжки делает', 5, 1.1, '{\"движение\":\"прыжки\"}', (10,11), 'кот', 1, '2025-03-11 12:00:00', (111111111, 222222222), (0.9, 0.8, 0.7, 0.6));"; echo $?
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl2 on port $port:"; mysql -h0 -P$port -e "SELECT id, f, HIGHLIGHT() FROM c:tbl2 WHERE MATCH('прыжок');"; done
––– output –––
OK
––– input –––
for port in 1306 2306 3306; do echo "Data from c:tbl2 on port $port:"; mysql -h0 -P$port -e "SELECT * FROM c:tbl2 ORDER BY id ASC;"; done
––– output –––
OK
––– input –––
rm -f /tmp/stopwords.txt /tmp/exceptions.txt /tmp/wordforms.txt /var/lib/manticore/tbl3.conf dump.sql
––– output –––
OK |
Nick-S-2018
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.