Fix APP_VERSION missing from macOS package - #575
Closed
sanikolaev wants to merge 2 commits into
Closed
Conversation
🐳 Docker Images PushedBuddy Test-Kit Images:
Base image used: These images contain the buddy code from this PR and can be used for testing. |
sanikolaev
commented
Jul 1, 2025
Collaborator
Author
|
Pls review this PR from Codex. Does it make sense at all? |
🐳 Docker Images PushedBuddy Test-Kit Images:
Base image used: These images contain the buddy code from this PR and can be used for testing. |
Collaborator
Author
|
The related issue is #571 |
Member
|
This won't work because it is not addressing the root cause. APP_VERSION exists; adding it this way is not correct and will not solve the issue. Closing as fixed version here now: #578 |
donhardman
reviewed
Jul 10, 2025
donhardman
left a comment
donhardman
left a comment
Member
There was a problem hiding this comment.
This is not going to fix the root cause
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APP_VERSIONwhen creating release artifacts so macOS packages show the right versionTesting
composer install --prefer-dist --ignore-platform-req=ext-rdkafka./bin/test(fails: Class "Swoole\Table" not found)https://chatgpt.com/codex/tasks/task_e_6863931b1344832d9d7193982b3f9849