Fix compatibility of ResultSet with php 8.1+#71
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
=============================================
- Coverage 82.41% 46.42% -35.99%
Complexity 633 633
=============================================
Files 89 89
Lines 1717 1708 -9
=============================================
- Hits 1415 793 -622
- Misses 302 915 +613 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @donhardman I've added yaml for github actions (we were previously using travis ci). Can you please add php 8.1 to the matrix (https://github.com/manticoresoftware/manticoresearch-php/blob/master/.github/workflows/ci.yml#L17) and make sure your change passes the tests in the new version? |
|
@sanikolaev Одобрите, пожалуйста. Нехорошо, что в логи постоянно валятся предупреждения. |
@Fot0n asked to approve the PR. The problem is that we are waiting for a little improvement in the tests, but we can do it ourselves. Thanks for pushing this @Fot0n! |
|
Done in #97 |
No description provided.