Skip to content

Fix compatibility of ResultSet with php 8.1+#71

Closed
donhardman wants to merge 1 commit into
manticoresoftware:masterfrom
donhardman:master
Closed

Fix compatibility of ResultSet with php 8.1+#71
donhardman wants to merge 1 commit into
manticoresoftware:masterfrom
donhardman:master

Conversation

@donhardman

Copy link
Copy Markdown
Member

No description provided.

@codecov-commenter

codecov-commenter commented Dec 29, 2021

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.42%. Comparing base (1636c41) to head (ee0a02e).
⚠️ Report is 187 commits behind head on master.

Files with missing lines Patch % Lines
src/Manticoresearch/ResultSet.php 33.33% 4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff              @@
##             master      #71       +/-   ##
=============================================
- Coverage     82.41%   46.42%   -35.99%     
  Complexity      633      633               
=============================================
  Files            89       89               
  Lines          1717     1708        -9     
=============================================
- Hits           1415      793      -622     
- Misses          302      915      +613     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sanikolaev

Copy link
Copy Markdown
Collaborator

Hi @donhardman

I've added yaml for github actions (we were previously using travis ci). Can you please add php 8.1 to the matrix (https://github.com/manticoresoftware/manticoresearch-php/blob/master/.github/workflows/ci.yml#L17) and make sure your change passes the tests in the new version?

@Fot0n

Fot0n commented Jul 17, 2022

Copy link
Copy Markdown

@sanikolaev Одобрите, пожалуйста. Нехорошо, что в логи постоянно валятся предупреждения.

@sanikolaev

Copy link
Copy Markdown
Collaborator

@sanikolaev Одобрите, пожалуйста. Нехорошо, что в логи постоянно валятся предупреждения.

@Fot0n asked to approve the PR. The problem is that we are waiting for a little improvement in the tests, but we can do it ourselves. Thanks for pushing this @Fot0n!

@Nick-S-2018

Copy link
Copy Markdown
Collaborator

Done in #97

@Nick-S-2018 Nick-S-2018 closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants