Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload indexes for rt_index in 2.8.0 #161

Closed
iivanov opened this issue Feb 5, 2019 · 5 comments
Closed

reload indexes for rt_index in 2.8.0 #161

iivanov opened this issue Feb 5, 2019 · 5 comments

Comments

@iivanov
Copy link

@iivanov iivanov commented Feb 5, 2019

RELOAD INDEXES doesn't work with rt_intexes in manticore 2.8.0

Changelog: fixed issues with RELOAD INDEXES and now all indexes (include percolate and RT) should be loaded or reloaded after config changed

@githubmanticore
Copy link
Contributor

@githubmanticore githubmanticore commented Feb 5, 2019

➤ Stan commented:

that feature was removed at replication branch as loading indexes from replication thread cause deadlocks between replication thread and system rotation thread and another issue that system rotation thread picks indexes faster than replication thread and cause SST failure.

We might revert my change and get this feature back however add check for rotation to skip indexes from JSON config or indexes these part of cluster.

@githubmanticore
Copy link
Contributor

@githubmanticore githubmanticore commented Feb 6, 2019

➤ Stan commented:

PQ and RT index rotation was removed at master branch and fix of rotation at RotationThreadFunc around FIXME!!! ... comment might be rolled back to original state but also need additional check that Rotation does not touch JSON or cluster indexes.

I could do this ticket after you finish refactor of locks at daemon.

@johnbarratt
Copy link

@johnbarratt johnbarratt commented Feb 20, 2019

This is a critical issue for us, 2.8 cannot be used without ability to reload indexes via a HUP or a RELOAD INDEXES command. I am very surprised that the removal of this core feature was not at least documented and highlighted with the release as a breaking change. We are still seeing issues with indexes not being rotated in with 2.7.X, but this has made the situation far worse.

@tomatolog
Copy link
Contributor

@tomatolog tomatolog commented Feb 20, 2019

We are going to fix this issue this release. RT and PQ indexes will be reloaded well.

@githubmanticore
Copy link
Contributor

@githubmanticore githubmanticore commented Feb 21, 2019

➤ Stan commented:

I've just fixed issues with RELOAD INDEXES. Now all indexes (include PQ and RT) should be loaded after config changed, ie

  • adding a new index or removing it from configuration followed by a HUP \ RELOAD INDEXES will load/remove that index without daemon restart
  • changing the type of an index in config followed by HUP \ RELOAD INDEXES will actually change the type of that index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants