Invalid error when executing the CREATE TABLE command with the shards parameter set as a non-numeric value

[PavelShilin89]

Bug Description:

When executing a CREATE TABLE command with the shards parameter specified as a non-numeric value (e.g. abc), Manticore Search returns a syntax error, but the error message does not reflect the nature of the problem. The current output indicates “unexpected tablename”, which is confusing, rather than explicitly reporting an invalid value for shards. This should not create a table.

MRE

~ searchd
~ mysql -h0 -P1306 -e "CREATE TABLE tbl4 shards=abc rf=1;"

Manticore Search Version:

Manticore 7.4.7 e8a71318d@25031620 dev (columnar 4.1.2 15bbcc7@25031206) (secondary 4.1.2 15bbcc7@25031206) (knn 4.1.2 15bbcc7@25031206)

Operating System Version:

Ubuntu 22.04.5 LTS (Jammy Jellyfish)

Have you tried the latest development version?

Yes

Internal Checklist:

^{To be completed by the assignee. Check off tasks that have been completed or are not applicable.}

Details

• Implementation completed
• Tests developed
• Documentation updated
• Documentation reviewed
• Changelog updated

[donhardman]

The error is valid and we display this error for any options passed in the same way, so there is nothing to improve on buddy side.

mysql> CREATE TABLE tbl4 min_infix_len=abc;
ERROR 1064 (42000): P03: syntax error, unexpected tablename, expecting string near 'abc'
mysql>