diff --git a/Framework/API/src/IFunction.cpp b/Framework/API/src/IFunction.cpp index 5f02a460ff1c..e63e6031f5be 100644 --- a/Framework/API/src/IFunction.cpp +++ b/Framework/API/src/IFunction.cpp @@ -418,7 +418,7 @@ IConstraint *IFunction::getConstraint(size_t i) const { void IFunction::removeConstraint(const std::string &parName) { size_t iPar = parameterIndex(parName); const auto it = std::find_if(m_constraints.cbegin(), m_constraints.cend(), - [&iPar](const auto &constraint) { return constraint->getLocalIndex == iPar; }); + [&iPar](const auto &constraint) { return iPar == constraint->getLocalIndex(); }); if (it != m_constraints.cend()) { m_constraints.erase(it); } @@ -455,7 +455,7 @@ void IFunction::setUpForFit() { std::string IFunction::writeConstraints() const { std::ostringstream stream; bool first = true; - for (auto &constrint : m_constraints) { + for (const auto &constrint : m_constraints) { if (constrint->isDefault()) continue; if (!first) { @@ -729,7 +729,7 @@ std::string IFunction::Attribute::asUnquotedString() const { if (*(attr.begin()) == '\"') unquoted = std::string(attr.begin() + 1, attr.end() - 1); if (*(unquoted.end() - 1) == '\"') - unquoted = std::string(unquoted.begin(), unquoted.end() - 1); + unquoted.resize(unquoted.size() - 1); return unquoted; } @@ -1673,7 +1673,8 @@ IPropertyManager::getValue>(const std::s template <> MANTID_API_DLL std::shared_ptr IPropertyManager::getValue>(const std::string &name) const { - auto *prop = dynamic_cast> *>(getPointerToProperty(name)); + const auto *prop = + dynamic_cast> *>(getPointerToProperty(name)); if (prop) { return prop->operator()(); } else { diff --git a/Framework/Algorithms/inc/MantidAlgorithms/FitPeaks.h b/Framework/Algorithms/inc/MantidAlgorithms/FitPeaks.h index e5c8cd554d7d..c9fb198fd7bf 100644 --- a/Framework/Algorithms/inc/MantidAlgorithms/FitPeaks.h +++ b/Framework/Algorithms/inc/MantidAlgorithms/FitPeaks.h @@ -214,7 +214,7 @@ class MANTID_ALGORITHMS_DLL FitPeaks final : public API::Algorithm { const std::shared_ptr &fit_result); /// calculate peak+background for fitted - void calculateFittedPeaks(std::vector> fit_results); + void calculateFittedPeaks(const std::vector> &fit_results); /// Get the parameter name for peak height (I or height or etc) std::string getPeakHeightParameterName(const API::IPeakFunction_const_sptr &peak_function); diff --git a/Framework/Algorithms/src/ConvertUnits.cpp b/Framework/Algorithms/src/ConvertUnits.cpp index 1b58101d9290..984be49f9380 100644 --- a/Framework/Algorithms/src/ConvertUnits.cpp +++ b/Framework/Algorithms/src/ConvertUnits.cpp @@ -318,7 +318,7 @@ MatrixWorkspace_sptr ConvertUnits::convertQuickly(const API::MatrixWorkspace_con if (commonBoundaries) { // Calculate the new (common) X values std::transform(outputWS->mutableX(0).cbegin(), outputWS->mutableX(0).cend(), outputWS->mutableX(0).begin(), - [&](auto &x) { return factor * std::pow(x, power); }); + [&](const auto &x) { return factor * std::pow(x, power); }); auto xVals = outputWS->sharedX(0); @@ -345,7 +345,7 @@ MatrixWorkspace_sptr ConvertUnits::convertQuickly(const API::MatrixWorkspace_con PARALLEL_START_INTERRUPT_REGION if (!commonBoundaries) { std::transform(outputWS->mutableX(k).cbegin(), outputWS->mutableX(k).cend(), outputWS->mutableX(k).begin(), - [&](auto &x) { return factor * std::pow(x, power); }); + [&](const auto &x) { return factor * std::pow(x, power); }); } // Convert the events themselves if necessary. if (m_inputEvents) { diff --git a/Framework/Algorithms/src/FitPeaks.cpp b/Framework/Algorithms/src/FitPeaks.cpp index 2c039963286f..6e1189e4309a 100644 --- a/Framework/Algorithms/src/FitPeaks.cpp +++ b/Framework/Algorithms/src/FitPeaks.cpp @@ -497,7 +497,7 @@ std::map FitPeaks::validateInputs() { // check that the supplied names are in the function // it is acceptable to be missing parameters const bool failed = std::any_of(suppliedParameterNames.cbegin(), suppliedParameterNames.cend(), - [&functionParameterNames](const auto &parNme) { + [&functionParameterNames](const auto &parName) { return std::find(functionParameterNames.begin(), functionParameterNames.end(), parName) == functionParameterNames.end(); }); @@ -1470,7 +1470,7 @@ bool FitPeaks::processSinglePeakFitResult(size_t wsindex, size_t peakindex, cons * fitted parameter * table */ -void FitPeaks::calculateFittedPeaks(std::vector> fit_results) { +void FitPeaks::calculateFittedPeaks(const std::vector> &fit_results) { // check if (!m_fittedParamTable) throw std::runtime_error("No parameters"); diff --git a/Framework/CurveFitting/src/Functions/ProcessBackground.cpp b/Framework/CurveFitting/src/Functions/ProcessBackground.cpp index 9866bc5042fe..6166ff11ef7a 100644 --- a/Framework/CurveFitting/src/Functions/ProcessBackground.cpp +++ b/Framework/CurveFitting/src/Functions/ProcessBackground.cpp @@ -503,7 +503,7 @@ void ProcessBackground::selectFromGivenFunction() { auto bkgdorder = static_cast(parmap.size() - 1); // A0 - A(n) total n+1 parameters bkgdfunc->setAttributeValue("n", bkgdorder); - for (auto &mit : parmap) { + for (const auto &mit : parmap) { string parname = mit.first; double parvalue = mit.second; bkgdfunc->setParameter(parname, parvalue); diff --git a/Framework/DataHandling/inc/MantidDataHandling/LoadHelper.h b/Framework/DataHandling/inc/MantidDataHandling/LoadHelper.h index ebf22b494c1f..502e849bb0be 100644 --- a/Framework/DataHandling/inc/MantidDataHandling/LoadHelper.h +++ b/Framework/DataHandling/inc/MantidDataHandling/LoadHelper.h @@ -55,8 +55,8 @@ NeXus::NXDouble getDoubleDataset(const NeXus::NXEntry &, const std::string &); void replaceZeroErrors(const API::MatrixWorkspace_sptr &, double); -void recurseAndAddNexusFieldsToWsRun(NXhandle nxfileID, API::Run &runDetails, std::string &parent_name, - std::string &parent_class, int level, bool useFullPath); +void recurseAndAddNexusFieldsToWsRun(NXhandle nxfileID, API::Run &runDetails, const std::string &parent_name, + const std::string &parent_class, int level, bool useFullPath); } // namespace LoadHelper } // namespace DataHandling } // namespace Mantid diff --git a/Framework/DataHandling/inc/MantidDataHandling/LoadRawHelper.h b/Framework/DataHandling/inc/MantidDataHandling/LoadRawHelper.h index 5d6244d686ba..8da3871f4889 100644 --- a/Framework/DataHandling/inc/MantidDataHandling/LoadRawHelper.h +++ b/Framework/DataHandling/inc/MantidDataHandling/LoadRawHelper.h @@ -68,7 +68,7 @@ class MANTID_DATAHANDLING_DLL LoadRawHelper : public API::IFileLoader eventfile(dataDir + eventFilename); // Factor of 2 for compression wkspSizeGiB += static_cast(eventfile.getNumElements()) * 48.0 * BYTES_TO_GiB; diff --git a/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp b/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp index 8c72188baef0..36be907f055e 100644 --- a/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp +++ b/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp @@ -264,7 +264,7 @@ void LoadDetectorsGroupingFile::setByDetectors() { const detid2index_map indexmap = m_groupWS->getDetectorIDToWorkspaceIndexMap(true); // 2. Set GroupingWorkspace - for (auto &detectorMap : m_groupDetectorsMap) { + for (const auto &detectorMap : m_groupDetectorsMap) { g_log.debug() << "Group ID = " << detectorMap.first << '\n'; for (auto detid : detectorMap.second) { diff --git a/Framework/DataHandling/src/LoadHelper.cpp b/Framework/DataHandling/src/LoadHelper.cpp index 41e4f7096158..1b84a72ab71d 100644 --- a/Framework/DataHandling/src/LoadHelper.cpp +++ b/Framework/DataHandling/src/LoadHelper.cpp @@ -163,8 +163,9 @@ void LoadHelper::addNexusFieldsToWsRun(NXhandle nxfileID, API::Run &runDetails, * @param useFullPath :: use full path to entry in nexus tree to generate the log entry name in Mantid * */ -void LoadHelper::recurseAndAddNexusFieldsToWsRun(NXhandle nxfileID, API::Run &runDetails, std::string &parent_name, - std::string &parent_class, int level, bool useFullPath) { +void LoadHelper::recurseAndAddNexusFieldsToWsRun(NXhandle nxfileID, API::Run &runDetails, + const std::string &parent_name, const std::string &parent_class, + int level, bool useFullPath) { // Classes NXstatus getnextentry_status; ///< return status int datatype; ///< NX data type if a dataset, e.g. NX_CHAR, NX_FLOAT32, see diff --git a/Framework/DataHandling/src/LoadILLPolarizationFactors.cpp b/Framework/DataHandling/src/LoadILLPolarizationFactors.cpp index 397125bf8abd..15446ae76737 100644 --- a/Framework/DataHandling/src/LoadILLPolarizationFactors.cpp +++ b/Framework/DataHandling/src/LoadILLPolarizationFactors.cpp @@ -79,7 +79,7 @@ std::string cleanse_comments(const std::string &l) { } /// Removes whitspace from 'l'. -void cleanse_whitespace(std::string &l) { l.erase(std::remove_if(l.begin(), l.end(), !isblank), l.end()); } +void cleanse_whitespace(std::string &l) { l.erase(std::remove_if(l.begin(), l.end(), isspace), l.end()); } /// Returns true if `l` contains the limits array. bool contains_limits(const std::string &l) { return l.find("_limits") != std::string::npos; } @@ -144,7 +144,7 @@ std::map parse(std::istream &in) { } catch (std::exception &e) { throw std::runtime_error(std::string("Unknown exception: ") + e.what()); } - l = cleanse_whitespace(l); + cleanse_whitespace(l); l = cleanse_comments(l); if (l.empty()) continue; diff --git a/Framework/DataHandling/src/LoadNexusMonitors2.cpp b/Framework/DataHandling/src/LoadNexusMonitors2.cpp index 2a955a5d758e..e2542bbfdc59 100644 --- a/Framework/DataHandling/src/LoadNexusMonitors2.cpp +++ b/Framework/DataHandling/src/LoadNexusMonitors2.cpp @@ -176,7 +176,6 @@ void LoadNexusMonitors2::exec() { // open the correct entry using string_map_t = std::map; - string_map_t::const_iterator it; string_map_t entries = file.getEntries(); if (m_top_entry_name.empty()) { diff --git a/Framework/DataHandling/src/LoadRawHelper.cpp b/Framework/DataHandling/src/LoadRawHelper.cpp index bc6560dec05f..e9f131214976 100644 --- a/Framework/DataHandling/src/LoadRawHelper.cpp +++ b/Framework/DataHandling/src/LoadRawHelper.cpp @@ -998,7 +998,7 @@ void LoadRawHelper::calculateWorkspacesizes(const std::vector &monito } else if (m_interval || m_bmspeclist) { if (m_interval) { int msize = std::count_if(monitorSpecList.cbegin(), monitorSpecList.cend(), - [](const auto &spec) { return (spec >= m_spec_min && spec < m_spec_min); }); + [](const auto &spec) { return (spec >= m_spec_min && spec < m_spec_max); }); monitorwsSpecs = msize; normalwsSpecs = m_total_specs - monitorwsSpecs; g_log.debug() << "normalwsSpecs when m_interval true is " << normalwsSpecs << " monitorwsSpecs is " @@ -1055,7 +1055,7 @@ void LoadRawHelper::loadSpectra(FILE *file, const int &period, const int &total_ int64_t histCurrent = -1; int64_t wsIndex = 0; - auto &isisRawRef = isisRaw(); + const auto &isisRawRef = isisRaw(); auto numberOfPeriods = static_cast(isisRawRef.t_nper); auto histTotal = static_cast(total_specs * numberOfPeriods); int64_t noTimeRegimes = getNumberofTimeRegimes(); @@ -1198,7 +1198,7 @@ bool LoadRawHelper::isSeparateMonitors(const std::string &monitorOption) { retur * property. */ void LoadRawHelper::ProcessLoadMonitorOptions(bool &bincludeMonitors, bool &bseparateMonitors, bool &bexcludeMonitors, - API::Algorithm *pAlgo) { + const API::Algorithm *pAlgo) { // process monitor option std::string monitorOption = pAlgo->getProperty("LoadMonitors"); if (monitorOption == "1") diff --git a/Framework/Geometry/src/Instrument.cpp b/Framework/Geometry/src/Instrument.cpp index 5eb06b495fd3..ed82bb822103 100644 --- a/Framework/Geometry/src/Instrument.cpp +++ b/Framework/Geometry/src/Instrument.cpp @@ -753,7 +753,7 @@ void Instrument::getBoundingBox(BoundingBox &assemblyBox) const { m_cachedBoundingBox = new BoundingBox(); ComponentID sourceID = getSource()->getComponentID(); // Loop over the children and define a box large enough for all of them - for (auto component : m_children) { + for (const auto component : m_children) { BoundingBox compBox; if (component && component->getComponentID() != sourceID) { component->getBoundingBox(compBox); @@ -793,7 +793,7 @@ std::shared_ptr> Instrument::getPlot void Instrument::appendPlottable(const CompAssembly &ca, std::vector &lst) const { for (int i = 0; i < ca.nelements(); i++) { IComponent *c = ca[i].get(); - auto *a = dynamic_cast(c); + const auto *a = dynamic_cast(c); if (a) appendPlottable(*a, lst); else { diff --git a/buildconfig/CMake/CppCheck_Suppressions.txt.in b/buildconfig/CMake/CppCheck_Suppressions.txt.in index 7c8325e01411..d44b38073c9e 100644 --- a/buildconfig/CMake/CppCheck_Suppressions.txt.in +++ b/buildconfig/CMake/CppCheck_Suppressions.txt.in @@ -241,7 +241,6 @@ duplicateExpression:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FitPeaks.cpp:44 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/NormaliseByCurrent.cpp:61 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/NormaliseByCurrent.cpp:66 passedByValue:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/MedianDetectorTest.cpp:280 -passedByValue:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FitPeaks.cpp:1476 uselessOverride:${CMAKE_SOURCE_DIR}/Framework/Algorithms/inc/MantidAlgorithms/Power.h:48 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/GenerateEventsFilter.cpp:752 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/GenerateEventsFilter.cpp:1804 @@ -296,7 +295,6 @@ uselessOverride:${CMAKE_SOURCE_DIR}/Framework/Algorithms/inc/MantidAlgorithms/So constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/AlgorithmHasProperty.cpp:36 operatorEqVarError:${CMAKE_SOURCE_DIR}/Framework/API/src/AlgorithmHistory.cpp:230 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/API/src/AlgorithmHistory.cpp:274 -constParameterPointer:${CMAKE_SOURCE_DIR}/Framework/API/src/AlgorithmManager.cpp:112 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/Stitch1DMany.cpp:291 uselessOverride:${CMAKE_SOURCE_DIR}/Framework/API/inc/MantidAPI/AnalysisDataService.h:138 constParameterPointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/UnwrapMonitorsInTOF.cpp:65 @@ -409,14 +407,11 @@ constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Crystal/src/IndexSXPeaks.cp shadowFunction:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:263 shadowFunction:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:313 shadowFunction:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:325 -shadowFunction:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:1608 -shadowFunction:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:1651 +shadowFunction:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:1607 +shadowFunction:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:1650 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:263 -constVariableReference:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:459 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:285 -constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:1608 -constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:1677 -uselessCallsConstructor:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:733 +constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/IFunction.cpp:1607 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/Crystal/src/PeakStatisticsTools.cpp:209 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/MatrixWorkspace.cpp:383 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/MatrixWorkspace.cpp:405 @@ -580,9 +575,8 @@ constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/H5Util.cpp constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/H5Util.cpp:191 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/DataBlockComposite.cpp:383 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/IFittingAlgorithm.cpp:230 +passedByValue:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/Functions/ProcessBackground.cpp:898 passedByValue:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/Functions/ProcessBackground.cpp:899 -passedByValue:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/Functions/ProcessBackground.cpp:900 -constVariableReference:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/Functions/ProcessBackground.cpp:507 containerOutOfBounds:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/CreatePolarizationEfficiencies.cpp:119 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/CreateChunkingFromInstrument.cpp:415 uselessCallsSubstr:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/CreateChunkingFromInstrument.cpp:422 @@ -599,8 +593,7 @@ uselessOverride:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandlin passedByValue:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/BitStream.h:30 passedByValue:${CMAKE_SOURCE_DIR}/Framework/Kernel/inc/MantidKernel/BinaryFile.h:52 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadDspacemap.cpp:342 -nullPointerRedundantCheck:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp:221 -constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp:280 +nullPointerRedundantCheck:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp:213 knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadAscii2.cpp:211 duplicateConditionalAssign:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadCalFile.cpp:307 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/GroupDetectors2.cpp:58 @@ -610,7 +603,6 @@ unreadVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadANSTOHelper.cp uninitMemberVarPrivate:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/LoadHFIRSANS.h:124 uninitMemberVarPrivate:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/LoadHFIRSANS.h:125 uninitMemberVarPrivate:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/LoadHFIRSANS.h:126 -constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/DetermineChunking.cpp:144 uselessCallsSubstr:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadFITS.cpp:547 passedByValue:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadGSS.cpp:449 duplicateCondition:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/FilterEventsByLogValuePreNexus.cpp:1842 @@ -629,8 +621,6 @@ constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadEventP constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadEventPreNexus2.cpp:942 uselessCallsSubstr:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadEventPreNexus2.cpp:582 uselessCallsSubstr:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadEventPreNexus2.cpp:589 -constParameterReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadHelper.cpp:170 -constParameterReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadHelper.cpp:171 mismatchingContainerExpression:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadInstrument.cpp:148 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadLog.cpp:448 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadILLTOF2.cpp:177 @@ -662,7 +652,7 @@ unreadVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadILLReflectomet constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadMcStas.cpp:97 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadMLZ.cpp:172 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadMLZ.cpp:355 -knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadNexusMonitors2.cpp:453 +knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadNexusMonitors2.cpp:452 uselessOverride:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/LoadNexusProcessed2.h:38 uselessOverride:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/LoadPSIMuonBin.h:74 cstyleCast:${CMAKE_SOURCE_DIR}/Framework/Nexus/inc/MantidNexus/NexusFileIO.h:207 @@ -686,8 +676,6 @@ constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadMuonNe constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadMuonNexus2.cpp:486 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadTBL.cpp:133 unreadVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadTBL.cpp:162 -constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadRawHelper.cpp:1062 -constParameterPointer:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadRawHelper.cpp:1205 knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadSpiceXML2DDet.cpp:814 cstyleCast:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadSpiceXML2DDet.cpp:481 cstyleCast:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadSpiceXML2DDet.cpp:483 @@ -718,13 +706,13 @@ constParameterReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadNexus constParameterReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadNexusProcessed.cpp:1179 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadNexusProcessed.cpp:1965 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadNexusProcessed.cpp:425 -shadowVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:388 shadowVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:389 -shadowVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:598 -shadowVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:609 +shadowVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:390 +shadowVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:599 shadowVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:610 -constVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:695 -constVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:700 +shadowVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:611 +constVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:696 +constVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveISISNexus.cpp:701 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveCanSAS1D.cpp:32 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveCanSAS1D.cpp:397 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveCanSAS1D2.cpp:24 @@ -733,7 +721,7 @@ constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveFullpr constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveGSASInstrumentFile.cpp:222 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveGSASInstrumentFile.cpp:244 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveGSASInstrumentFile.cpp:328 -useStlAlgorithm:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveDiffCal.cpp:164 +useStlAlgorithm:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveDiffCal.cpp:158 unusedStructMember:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveGSASInstrumentFile.cpp:67 unusedStructMember:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveGSASInstrumentFile.cpp:68 shadowVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadTOFRawNexus.cpp:285 @@ -828,10 +816,8 @@ constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/DataObjects/src/EventWorkspac constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/DataObjects/src/EventWorkspace.cpp:738 constParameterPointer:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Instrument/XMLInstrumentParameter.cpp:92 stlIfStrFind:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Instrument/XMLInstrumentParameter.cpp:146 -shadowFunction:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Instrument.cpp:631 -shadowFunction:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Instrument.cpp:644 -constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Instrument.cpp:758 -constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Instrument.cpp:798 +shadowFunction:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Instrument.cpp:629 +shadowFunction:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Instrument.cpp:642 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Instrument/ObjCompAssembly.cpp:346 constParameterPointer:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Rendering/vtkGeometryCacheReader.cpp:64 constParameterPointer:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Rendering/vtkGeometryCacheWriter.cpp:83 @@ -1511,4 +1497,4 @@ constParameterReference:${CMAKE_SOURCE_DIR}/qt/scientific_interfaces/Inelastic/C virtualCallInConstructor:${CMAKE_SOURCE_DIR}/qt/scientific_interfaces/Inelastic/QENSFitting/FitDataView.h:42 internalError:${CMAKE_SOURCE_DIR}/Framework/MDAlgorithms/src/SliceMD.cpp:0 useStlAlgorithm:${CMAKE_SOURCE_DIR}/qt/scientific_interfaces/Indirect/Reduction/ISISEnergyTransferModelUtils.h:52 - +derefInvalidIteratorRedundantCheck:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/ExcludeRangeFinder.cpp:77