New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LoadParameterFile access instrument in proper manner #9365

Open
KarlPalmen opened this Issue Nov 27, 2013 · 1 comment

Comments

2 participants
@KarlPalmen
Copy link
Contributor

KarlPalmen commented Nov 27, 2013

This issue was originally TRAC 8521

Line 107 in LoadParameterFile has a dodgy pointer cast as explained in comment above it

  // TODO: Refactor to remove the need for the const cast
  Instrument_sptr instrument = boost::const_pointer_cast`<Instrument>`(localWorkspace->getInstrument()->baseInstrument());

This ticket is basically that TODO.

It has not yet caused a known problem, but the functionality of the code is useful for putting parameters into a workspace (e.g. from a fullprof file).


Keywords: maintenance

@KarlPalmen

This comment has been minimized.

Copy link
Contributor

KarlPalmen commented Feb 14, 2014

@NickDraper (2014-02-14T11:07:54):
bulk move to assigned at the into of the triage step

@NickDraper NickDraper added this to the Release 3.6 milestone Oct 2, 2015

@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016

@NickDraper NickDraper modified the milestone: Release 3.7 May 20, 2016

@SimonHeybrock SimonHeybrock referenced this issue Sep 28, 2017

Merged

LoadEventNexus MPI support #20559

0 of 7 tasks complete

@peterfpeterson peterfpeterson added this to Next in Maintenance Nov 20, 2018

@peterfpeterson peterfpeterson moved this from Next to To do in Maintenance Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment