Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printf coverity errors in OPJFile.cpp #12767

Merged
merged 1 commit into from Jun 8, 2015

Conversation

eXeC64
Copy link
Contributor

@eXeC64 eXeC64 commented Jun 8, 2015

Fixes #12766

@eXeC64 eXeC64 added Maintenance Unassigned issues to be addressed in the next maintenance period. Coverity labels Jun 8, 2015
@eXeC64 eXeC64 added this to the Release 3.5 milestone Jun 8, 2015
@FedeMPouzols FedeMPouzols self-assigned this Jun 8, 2015
@FedeMPouzols
Copy link
Contributor

@eXeC64 : do you know if %z will work well with MSVC. Apparently in Visual Studio 2013 they still don't have it (https://msdn.microsoft.com/en-us/library/vstudio/tcxf1dw6.aspx, http://stackoverflow.com/questions/15610053/correct-printf-format-specifier-for-size-t-zu-or-iu) as they "prefer" to use %I !

@eXeC64
Copy link
Contributor Author

eXeC64 commented Jun 8, 2015

@FedeMPouzols Their C compiler definitely doesn't have it, but their C++ compiler possibly has it. The %z format specifier is already being used in OPJFile.cpp elsewhere, so presumably it works. And if it doesn't, no one's noticed.

@FedeMPouzols
Copy link
Contributor

Oh ok, so let's merge this in. I'll check if it works with MSVC later.

FedeMPouzols added a commit that referenced this pull request Jun 8, 2015
…match

Fix printf coverity errors in OPJFile.cpp
@FedeMPouzols FedeMPouzols merged commit 74ced6c into master Jun 8, 2015
@FedeMPouzols FedeMPouzols deleted the 12766_opjfile_printf_mismatch branch June 8, 2015 15:56
eXeC64 added a commit that referenced this pull request Jun 11, 2015
This fixes a couple of issues I was supposed to fix, and missed in #12766 and #12767.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants