Nomad fixes #13116
Merged
Nomad fixes #13116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
added
Diffraction
|
The algorithm does not check whether minimum wavelength is smaller than maximum wavelength. It could be nicer if there is a warning message for the user in case such situation happens by mistake. |
|
Changes are reasonable via coding review. Tests for the new feature were passed. Issue is thus closed. |
wdzhou
added a commit
that referenced
this pull request
Jul 16, 2015
Changes to fix the issue with NOMAD are reasonable via coding review. Tests for the new feature were passed. Issue is thus closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They asked for the ability to specify a maximum wavelength cutoff and the radius of the vanadium rod.
The additions to the release notes are here.