Add multiple time regime support for ISIS loading #18561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow for multiple time regime loading of ISIS data. Our loading works correctly for files which have up to two time regimes. Rob has been using three time regimes which causes our LoadISISNexus2 algorithm to trip since it compares the number of detectors + monitors with the entry in
NSP1
of thevms_compat
. This comparison is not valid for this scenario, therefore the comparison is disabled when loadingFixes #18560
To test:
Test that can load a multiple time regime file
That that can load a normal file where the NSP1 is incorrect
You can get the sample file from here: \olympic\Babylon5\Scratch\Anton\BAD_LOQ_FILE_WRONG_NSP1
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Do changes function as described? Add comments below that describe the tests performed?
How do the changes handle unexpected situations, e.g. bad input?
Has the relevant documentation been added/updated?
Is user-facing documentation written in a user-friendly manner?
Has developer documentation been updated if required?
Does everything look good? Comment with the ship it emoji but don't merge. A member of
@mantidproject/gatekeepers
will take care of it.