Added check for if nonorthogonal axes should be displayed#18833
Merged
Conversation
lottiegreenwood
added
Diffraction
lottiegreenwood
added
the
Patch Candidate
Contributor
|
@lottiegreenwood Which data set did you use? The change makes sense and I saw the issue on your screen, but I am having trouble reproducing it. It works quite well with and without the fix. Maybe it is more visible with some data sets. |
Contributor
|
The changes make sense and I was able to reproduce the bug without the fix. With the fix the dimensions are displayed correctly. |
martyngigg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18832
To test, open a workspace with HKL axes. Change the dimensions shown and ensure the axes remain consistent. Switch back and forth between nonorthogonal and orthogonal modes and also check this.