-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in reflectometry GUI #18865
Fix bug in reflectometry GUI #18865
Conversation
Code looks fine. I ran the testing instructions - while both
The IvsQ and IvsQ_binned groups hold the same |
Actually, the above has nothing to do with your changes. |
Yes, I think it is unrelated to these changes, but given that you found it, I'd like to solve it as part of this PR, so if you could remove the squirrel I'll fix it. |
@PranavBahuguna could you test this again? |
Alright, workspaces are outputted correctly now.
|
Fixes a bug when no transmission runs provided.
To test:
INTER
and enter run13460
, hit process. The run should be reduced and workspaces13460_IvsQ
,13460_IvsLam
andTOF
(this one should be a group with a single entry) should be created in the ADS.POLREF
, enter run18564
and hitProcess
, no errors should be shown and the run should be reduced.Fixes #16925.
No need to update release notes, this issue was reported by a developer and picked by squish test.
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Do changes function as described? Add comments below that describe the tests performed?
How do the changes handle unexpected situations, e.g. bad input?
Has the relevant documentation been added/updated?
Is user-facing documentation written in a user-friendly manner?
Has developer documentation been updated if required?
Does everything look good? Comment with the ship it emoji but don't merge. A member of
@mantidproject/gatekeepers
will take care of it.