Fix bug in reflectometry GUI#18865
Merged
Merged
Conversation
Contributor
|
Code looks fine. I ran the testing instructions - while both The IvsQ and IvsQ_binned groups hold the same |
Contributor
|
Actually, the above has nothing to do with your changes. |
Contributor
Author
|
Yes, I think it is unrelated to these changes, but given that you found it, I'd like to solve it as part of this PR, so if you could remove the squirrel I'll fix it. |
Contributor
Author
|
@PranavBahuguna could you test this again? |
Contributor
|
Alright, workspaces are outputted correctly now.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug when no transmission runs provided.
To test:
INTERand enter run13460, hit process. The run should be reduced and workspaces13460_IvsQ,13460_IvsLamandTOF(this one should be a group with a single entry) should be created in the ADS.POLREF, enter run18564and hitProcess, no errors should be shown and the run should be reduced.Fixes #16925.
No need to update release notes, this issue was reported by a developer and picked by squish test.
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Do changes function as described? Add comments below that describe the tests performed?
How do the changes handle unexpected situations, e.g. bad input?
Has the relevant documentation been added/updated?
Is user-facing documentation written in a user-friendly manner?
Has developer documentation been updated if required?
Does everything look good? Comment with the ship it emoji but don't merge. A member of
@mantidproject/gatekeeperswill take care of it.