Fix mass ws deletion bug#18914
Merged
Merged
Conversation
samueljackson92
suggested changes
Feb 20, 2017
| vecWsNames.push_back(wsName.toStdString()); | ||
| } | ||
| alg->setProperty("WorkspaceList", vecWsNames); | ||
| executeAlgorithmAsync(alg); |
Contributor
There was a problem hiding this comment.
Maybe we should put all this in a private method? void MantidUI::deleteWorkspaces() or something?
Contributor
|
@NickDraper Also checked this with Giovanni's Mantid project and I cannot reproduce. |
samueljackson92
approved these changes
Feb 20, 2017
Contributor
|
LGTM |
martyngigg
pushed a commit
that referenced
this pull request
Feb 23, 2017
add DeleteWorkspaces algorithm, use it in GUI re #17729 (cherry picked from commit 9953f7c) clang format and release notes re #17729 (cherry picked from commit b6ba0e5) Resolve cppcheck warning re #17729 (cherry picked from commit 8827cbd) Resolve small syntax error (cherry picked from commit 1891682) Add release note for mass workspace fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17729
Added a DeleteWorkspaces algorithm, use it in GUI when deleting multiple workspaces, all it does is iterate over the list deleting workspaces.
To test:
* Test that deleting many workspaces does not crash*
* Test that deleting few very large data sets does not disturb the user experience (too much)*
RELEASE NOTES
docs/source/release/framework.rst
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Do changes function as described? Add comments below that describe the tests performed?
How do the changes handle unexpected situations, e.g. bad input?
Has the relevant documentation been added/updated?
Is user-facing documentation written in a user-friendly manner?
Has developer documentation been updated if required?
Does everything look good? Comment with the ship it emoji but don't merge. A member of
@mantidproject/gatekeeperswill take care of it.