Fix crash in MonitorDlg#18955
Merged
Merged
Conversation
martyngigg
approved these changes
Feb 22, 2017
Member
martyngigg
left a comment
There was a problem hiding this comment.
Adds a preventative check for a null pointer. This is actually required as the AlgorithmManager can in fact return a null pointer if the algorithm is not found it's managed list which could happen if the algorithm being queried has been knocked off the list.
![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids a potential crash when clicking the Details button to open the monitor dialog. It does not solve the root cause of the problem (an algorithm pointer being null) but stops mantid crashing if a null pointer is found.
To test:
The crash is intermittent and is not easily reproducible. The problem has been seen frequently by offspec users and we have managed to reproduce it under the debugger on their machine. They are testing a dev version with the same fix as this PR and so far have not seen the crash again.
Fixes #18951 .
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Do changes function as described? Add comments below that describe the tests performed?
How do the changes handle unexpected situations, e.g. bad input?
Has the relevant documentation been added/updated?
Is user-facing documentation written in a user-friendly manner?
Has developer documentation been updated if required?
Does everything look good? Comment with the ship it emoji but don't merge. A member of
@mantidproject/gatekeeperswill take care of it.