Blank instrument view with U correction #18959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/mantidproject/mantid into 18869_u_correction_instrument_view
samueljackson92
added
Component: GUI
Patch Candidate
| @@ -162,6 +162,7 @@ void RotationSurface::init() { | |||
| udet.u = applyUCorrection(udet.u); | |||
| } | |||
| } | |||
| updateViewRectForUCorrection(); | |||
There was a problem hiding this comment.
Does the text need to be indented so much from line 89 to 164? Otherwise it fixes the problem
There was a problem hiding this comment.
No, I tried to fix this in the previous PR but the code has detector info changes which I don't think we want in the patch release so I took that commit out.
|
Works for me. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the start up the instrument view doesn't draw the correct viewport unless a U correction is applied. This appears to have been missed in the original PR, probably because the U correction gets cached in the QSettings.
To test:
Follow the same instructions as in PR #18875.
Fixes #18869 .
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Do changes function as described? Add comments below that describe the tests performed?
How do the changes handle unexpected situations, e.g. bad input?
Has the relevant documentation been added/updated?
Is user-facing documentation written in a user-friendly manner?
Has developer documentation been updated if required?
Does everything look good? Comment with the ship it emoji but don't merge. A member of
@mantidproject/gatekeeperswill take care of it.