Fix reading dead time data in Muon interface#18972
Merged
Merged
Conversation
AnthonyLim23
added
Muon
Contributor
|
I noticed a change when the dead-time widget was changed from |
martyngigg
changed the title
martyngigg
pushed a commit
that referenced
this pull request
Feb 23, 2017
refs #18950 Forced deadTime data to be read during cache (cherry picked from commit a2b5275) refs #18950 Empty cache for deadTimes, firstGoodData and startTime (cherry picked from commit 67ea45d) refs #18950 Removed indent in DataLoader (cherry picked from commit 7efdc11) refs #18950 Renamed emptyCache to clearCache (cherry picked from commit abd3fe0) refs #18950 clang format (cherry picked from commit 786d435) Add patch release note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache in muon analysis is now cleared when the data is updated (change to the dead time correction, first good data and start time).
To test:
In muon analysis make sure that when the screen is generated "None" is selected for the dead time correction. Load some data and then change the dead time correction and the plot should be updated.
Fixes #18950 .
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Do changes function as described? Add comments below that describe the tests performed?
How do the changes handle unexpected situations, e.g. bad input?
Has the relevant documentation been added/updated?
Is user-facing documentation written in a user-friendly manner?
Has developer documentation been updated if required?
Does everything look good? Comment with the ship it emoji but don't merge. A member of
@mantidproject/gatekeeperswill take care of it.