Fix delete confirmations in workspace dock#18979
Merged
Merged
Conversation
samueljackson92
added
Component: GUI
Patch Candidate
martyngigg
approved these changes
Feb 24, 2017
Member
There was a problem hiding this comment.
Given the current structure of MantidPlot the code changes make sense to me and will at least allow us to reflect other config changes in external code.
I've tested the changes with creating several workspaces both grouped & ungrouped and deleting them with the option both on and off and the application responded as expected.
The state of the option is also preserved correctly between sessions.
LGTM 
martyngigg
added
the
High Priority
Member
|
I am including this in the patch so that it can help alleviate the problems with accidentally deleting workspaces when the dock is not focussed. See #18976 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes workspace deletion confirmations that are currently broken
To test:
Follow the reproduce steps in the bug report and check it is now fixed
Fixes #18978 .
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Do changes function as described? Add comments below that describe the tests performed?
How do the changes handle unexpected situations, e.g. bad input?
Has the relevant documentation been added/updated?
Is user-facing documentation written in a user-friendly manner?
Has developer documentation been updated if required?
Does everything look good? Comment with the ship it emoji but don't merge. A member of
@mantidproject/gatekeeperswill take care of it.