Add reduction for osiris diffspec#19022
Merged
Merged
Conversation
martyngigg
approved these changes
Mar 1, 2017
Member
martyngigg
left a comment
There was a problem hiding this comment.
Restores functionality that was accidentally removed in fixing a previous bug found in #18857.
I checked both modes on OSIRIS and each run the reduction and give the same result as 3.9.0.
![]()
Member
|
@mantidproject/gatekeepers The doc test failure is unrelated and one of the current crop of unstable tests. Can we get this merged ASAP, please? |
Contributor
|
@martyngigg Ah, was this supposed to be merged into |
Member
|
@SimonHeybrock Yes that's okay. For the patch we generally cherry-pick the commits from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a reduction step for OSIRIS diffspec when
Runis clickedTo test:
Interfaces>Indirect>Diffraction
Set instrument to OSIRIS, mode to diffspec
Input:
89813Calibration:
osiris_041_RES10.calInputs can be found in the unit tests
\Build\ExternalData\Testing\Data\UnitTestNo need for vanadium
Fixes #19021 .
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Do changes function as described? Add comments below that describe the tests performed?
How do the changes handle unexpected situations, e.g. bad input?
Has the relevant documentation been added/updated?
Is user-facing documentation written in a user-friendly manner?
Has developer documentation been updated if required?
Does everything look good? Comment with the ship it emoji but don't merge. A member of
@mantidproject/gatekeeperswill take care of it.