Correct angles for final banks in IN6 IDF #19080

Merged
merged 2 commits into from Mar 31, 2017

Conversation

Projects
None yet
3 participants
@ianbush
Member

ianbush commented Mar 7, 2017

A number of angles for the detector boxes were wrong in the IN6 IDF for banks > 102 degrees. This fixes that issue.

This PR also groups the detectors into top, middle and bottom banks.

To test:

Load up an IN6 data file (for example /ExternalData/Testing/Data/UnitTest/ILL/IN6/164192.nxs). Check that for higher bank numbers the combinations of theta and phi are unique (a given theta angle is used for a maximum of 3 detectors, each at a differnt phi angle). For example detectors 299 - 301 and 308 - 310 should now be different.

Check that in the instrument hierarchy the detector group contains top_bank, middle_bank and lower_bank.

Please also merge mantidproject/mantidgeometry#87 along with this.

Fixes #19079 .

Does not need to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@ianbush ianbush referenced this pull request in mantidproject/mantidgeometry Mar 23, 2017

Merged

Fix script to generate IN6 IDF #87

@DavidFair DavidFair self-assigned this Mar 30, 2017

@DavidFair

This comment has been minimized.

Show comment
Hide comment
@DavidFair

DavidFair Mar 30, 2017

Member

I'm seeing different theta angles (or phi angles per group of theta) as described. :shipit:

Member

DavidFair commented Mar 30, 2017

I'm seeing different theta angles (or phi angles per group of theta) as described. :shipit:

@peterfpeterson peterfpeterson merged commit 2ce794a into master Mar 31, 2017

9 checks passed

ClangFormat Jenkins build pull_requests-clang-format 12269 has succeeded
Details
Doxygen Jenkins build pull_requests-doxygen 11657 has succeeded
Details
Flake8 Jenkins build pull_requests-flake8 2973 has succeeded
Details
OSX Jenkins build pull_requests-osx 12808 has succeeded
Details
RHEL7 + System Tests Jenkins build pull_requests-rhel7 12710 has succeeded
Details
Ubuntu + Doc Tests Jenkins build pull_requests-ubuntu 13310 has succeeded
Details
Ubuntu Python 3 Jenkins build pull_requests-ubuntu-python3 859 has succeeded
Details
Windows Jenkins build pull_requests-win7 13579 has succeeded
Details
cppcheck Jenkins build pull_requests-cppcheck 13269 has succeeded
Details

@peterfpeterson peterfpeterson deleted the 19079_IN6_IDF_fix branch Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment