Change group font in Reflectometry GUI (Polref) #19099

Merged
merged 2 commits into from Mar 29, 2017

Conversation

Projects
None yet
3 participants
@PranavBahuguna
Contributor

PranavBahuguna commented Mar 8, 2017

See #18822 for description - increases font size of Group1/2 and makes them bold. The previous PR (#18863) only made changes for the Runs tab, hence the new PR.

To test:

Open the interface from Interfaces->Reflectometry->ISIS Reflectometry (Polref) and ensure the changes are there for the Runs, Event Handling and Settings tabs.

Fixes #18822.

Does not need to be in the release notes.

Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@raquelalvarezbanos

This comment has been minimized.

Show comment
Hide comment
@raquelalvarezbanos

raquelalvarezbanos Mar 16, 2017

Contributor

Changes also change fonts in the widgets contained in the groups:

reflectometry-table

The same happens in Event Handling. I think changes should only apply to labels Group 1 and Group 2.

Contributor

raquelalvarezbanos commented Mar 16, 2017

Changes also change fonts in the widgets contained in the groups:

reflectometry-table

The same happens in Event Handling. I think changes should only apply to labels Group 1 and Group 2.

@raquelalvarezbanos

This comment has been minimized.

Show comment
Hide comment
@raquelalvarezbanos

raquelalvarezbanos Mar 27, 2017

Contributor

Looks good. :shipit:

Contributor

raquelalvarezbanos commented Mar 27, 2017

Looks good. :shipit:

@ianbush ianbush self-assigned this Mar 29, 2017

@ianbush ianbush merged commit de09571 into master Mar 29, 2017

9 checks passed

ClangFormat Jenkins build pull_requests-clang-format 12141 has succeeded
Details
Doxygen Jenkins build pull_requests-doxygen 11592 has succeeded
Details
Flake8 Jenkins build pull_requests-flake8 2888 has succeeded
Details
OSX Jenkins build pull_requests-osx 12732 has succeeded
Details
RHEL7 + System Tests Jenkins build pull_requests-rhel7 12640 has succeeded
Details
Ubuntu + Doc Tests Jenkins build pull_requests-ubuntu 13233 has succeeded
Details
Ubuntu Python 3 Jenkins build pull_requests-ubuntu-python3 789 has succeeded
Details
Windows Jenkins build pull_requests-win7 13507 has succeeded
Details
cppcheck Jenkins build pull_requests-cppcheck 13181 has succeeded
Details

@ianbush ianbush deleted the 18822_Change_group_font_in_Ref_GUI branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment