Skip to content

New CNCS geometry 2017A#19129

Merged
quantumsteve merged 1 commit into
masterfrom
CNCS_geometry_2017A
Mar 14, 2017
Merged

New CNCS geometry 2017A#19129
quantumsteve merged 1 commit into
masterfrom
CNCS_geometry_2017A

Conversation

@AndreiSavici

Copy link
Copy Markdown
Member

New CNCS geometry

Does not need to be in the release notes.

To be merged on the morning of 03/14/2017, after 10 am (not before) US Eastern time

Please also merge mantidproject/mantidgeometry#88


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@AndreiSavici AndreiSavici added the Direct Inelastic Issues and pull requests related to direct inelastic label Mar 13, 2017
@AndreiSavici AndreiSavici added this to the Release 3.10 milestone Mar 13, 2017
@peterfpeterson peterfpeterson self-assigned this Mar 14, 2017
@peterfpeterson

Copy link
Copy Markdown
Member

LGTM :shipit: once the beam is off (not yet).

@quantumsteve
quantumsteve merged commit 04d09c4 into master Mar 14, 2017
@quantumsteve
quantumsteve deleted the CNCS_geometry_2017A branch March 14, 2017 16:02
@AnthonyLim23 AnthonyLim23 added the Patch Candidate Urgent issues that must be included in a patch following a release label Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Direct Inelastic Issues and pull requests related to direct inelastic Patch Candidate Urgent issues that must be included in a patch following a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants