Change padding for LOQ #19166

Merged
merged 2 commits into from Mar 27, 2017

Conversation

Projects
None yet
3 participants
@AntonPiccardoSelg
Contributor

AntonPiccardoSelg commented Mar 16, 2017

Fixes #19165

Support for higher run numbers was added

To test:

Requires testing at ISIS

  1. Set your instrument to LOQ
  2. Enable the data archive search
  3. Open the load dialog and type in 99738
  • Confirm that the workspace can be loaded

Does not need to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@raquelalvarezbanos

This comment has been minimized.

Show comment
Hide comment
@raquelalvarezbanos

raquelalvarezbanos Mar 27, 2017

Contributor

I was able to load run 99738. :shipit:

Contributor

raquelalvarezbanos commented Mar 27, 2017

I was able to load run 99738. :shipit:

@AntonPiccardoSelg

This comment has been minimized.

Show comment
Hide comment
@AntonPiccardoSelg

AntonPiccardoSelg Mar 27, 2017

Contributor

@mantidproject/gatekeepers This is ready to be merged

Contributor

AntonPiccardoSelg commented Mar 27, 2017

@mantidproject/gatekeepers This is ready to be merged

@SimonHeybrock SimonHeybrock merged commit 689c6be into master Mar 27, 2017

9 checks passed

ClangFormat Jenkins build pull_requests-clang-format 12095 has succeeded
Details
Doxygen Jenkins build pull_requests-doxygen 11558 has succeeded
Details
Flake8 Jenkins build pull_requests-flake8 2851 has succeeded
Details
OSX Jenkins build pull_requests-osx 12679 has succeeded
Details
RHEL7 + System Tests Jenkins build pull_requests-rhel7 12601 has succeeded
Details
Ubuntu + Doc Tests Jenkins build pull_requests-ubuntu 13191 has succeeded
Details
Ubuntu Python 3 Jenkins build pull_requests-ubuntu-python3 747 has succeeded
Details
Windows Jenkins build pull_requests-win7 13462 has succeeded
Details
cppcheck Jenkins build pull_requests-cppcheck 13142 has succeeded
Details

@SimonHeybrock SimonHeybrock deleted the 19165_loq_padding branch Mar 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment