ISIS Reflectometry interface: Fixed a couple of errors with the 'Open Table' dialog #19224

Merged
merged 3 commits into from Mar 29, 2017

Conversation

Projects
None yet
3 participants
@PranavBahuguna
Contributor

PranavBahuguna commented Mar 23, 2017

See related issue (#19212) for details. There are two separate bugs regarding when the dialog is brought up:

  • Opening a new table when current is dirty and clicking 'no' on the dialog brings it up a second time.
  • Clicking on 'Import .TBL' but closing it without importing still brings up the dialog.

To test:

  • The interface can be accessed from Interfaces->Reflectometry->ISIS Reflectometry.
  • On Runs tab, create a couple of tables by adding some details in their rows and save them. When clicking on Open Table to access a different table, you should see the 'Open Table' dialog and clicking 'no' or close button on this should not bring it up again.
  • Click on Import .TBL and close it without importing anything. The dialog should not be displayed.

Fixes #19212.

Does not need to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@AntonPiccardoSelg AntonPiccardoSelg self-assigned this Mar 28, 2017

@AntonPiccardoSelg

This comment has been minimized.

Show comment
Hide comment
@AntonPiccardoSelg

AntonPiccardoSelg Mar 29, 2017

Contributor

Both bugs are fixed in this PR. Please :shipit:

Contributor

AntonPiccardoSelg commented Mar 29, 2017

Both bugs are fixed in this PR. Please :shipit:

@ianbush ianbush self-assigned this Mar 29, 2017

@ianbush ianbush merged commit 40f1d2d into master Mar 29, 2017

9 checks passed

ClangFormat Jenkins build pull_requests-clang-format 12282 has succeeded
Details
Doxygen Jenkins build pull_requests-doxygen 11665 has succeeded
Details
Flake8 Jenkins build pull_requests-flake8 2981 has succeeded
Details
OSX Jenkins build pull_requests-osx 12814 has succeeded
Details
RHEL7 + System Tests Jenkins build pull_requests-rhel7 12718 has succeeded
Details
Ubuntu + Doc Tests Jenkins build pull_requests-ubuntu 13319 has succeeded
Details
Ubuntu Python 3 Jenkins build pull_requests-ubuntu-python3 868 has succeeded
Details
Windows Jenkins build pull_requests-win7 13587 has succeeded
Details
cppcheck Jenkins build pull_requests-cppcheck 13277 has succeeded
Details

@ianbush ianbush deleted the 19212_Open_table_dialog_errors branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment