Fixed ISIS_Reflectometry.rst build errors #19244

Merged
merged 2 commits into from Mar 29, 2017

Conversation

Projects
None yet
4 participants
@PranavBahuguna
Contributor

PranavBahuguna commented Mar 24, 2017

Originally, building the ISIS_Reflectometry.rst file produced the following errors:

UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry (Polref)" is not registered as an interface name.
InterfaceManager-[Error] Error creating interface ISIS Reflectometry (Polref)
UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry (Polref)" is not registered as an interface name.
InterfaceManager-[Error] Error creating interface ISIS Reflectometry (Polref)
UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry (Polref)" is not registered as an interface name.
InterfaceManager-[Error] Error creating interface ISIS Reflectometry (Polref)
UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry (Polref)" is not registered as an interface name.
InterfaceManager-[Error] Error creating interface ISIS Reflectometry (Polref)
UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry (Polref)" is not registered as an interface name.
InterfaceManager-[Error] Error creating interface ISIS Reflectometry (Polref)

This PR fixes the problem to ensure these errors don't turn up when building the doc.

To test:

Simply ensure no build errors turn up. The images related to the interface should also now be displayed in the built doc file.

Fixes #19232.

Does not need to be in the release notes.

Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@raquelalvarezbanos

This comment has been minimized.

Show comment
Hide comment
@raquelalvarezbanos

raquelalvarezbanos Mar 27, 2017

Contributor

There are still build errors:

10:32:14 UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry Old" is not registered as an interface name.
10:32:14 InterfaceManager-[Error] Error creating interface ISIS Reflectometry Old
10:32:14 UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry Old" is not registered as an interface name.
10:32:14 InterfaceManager-[Error] Error creating interface ISIS Reflectometry Old
10:32:14 UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry Old" is not registered as an interface name.
10:32:14 InterfaceManager-[Error] Error creating interface ISIS Reflectometry Old
10:32:14 UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry Old" is not registered as an interface name.
10:32:14 InterfaceManager-[Error] Error creating interface ISIS Reflectometry Old
10:32:14 UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry Old" is not registered as an interface name.
10:32:14 InterfaceManager-[Error] Error creating interface ISIS Reflectometry Old

See: http://builds.mantidproject.org/job/pull_requests-ubuntu/13327/consoleFull.

Note that this .rst file refers to the new interface, the one we used to call ISIS Reflectometry (Polref).

Contributor

raquelalvarezbanos commented Mar 27, 2017

There are still build errors:

10:32:14 UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry Old" is not registered as an interface name.
10:32:14 InterfaceManager-[Error] Error creating interface ISIS Reflectometry Old
10:32:14 UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry Old" is not registered as an interface name.
10:32:14 InterfaceManager-[Error] Error creating interface ISIS Reflectometry Old
10:32:14 UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry Old" is not registered as an interface name.
10:32:14 InterfaceManager-[Error] Error creating interface ISIS Reflectometry Old
10:32:14 UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry Old" is not registered as an interface name.
10:32:14 InterfaceManager-[Error] Error creating interface ISIS Reflectometry Old
10:32:14 UserSubWindowFactoryImpl-[Error] UserSubWindowFactory: "ISIS Reflectometry Old" is not registered as an interface name.
10:32:14 InterfaceManager-[Error] Error creating interface ISIS Reflectometry Old

See: http://builds.mantidproject.org/job/pull_requests-ubuntu/13327/consoleFull.

Note that this .rst file refers to the new interface, the one we used to call ISIS Reflectometry (Polref).

@DavidFair

This comment has been minimized.

Show comment
Hide comment
@DavidFair

DavidFair Mar 29, 2017

Member

This currently affects my branch so I'll reassign myself and test

Member

DavidFair commented Mar 29, 2017

This currently affects my branch so I'll reassign myself and test

@DavidFair

This comment has been minimized.

Show comment
Hide comment
@DavidFair

DavidFair Mar 29, 2017

Member

This resolves the build issues :shipit:

Member

DavidFair commented Mar 29, 2017

This resolves the build issues :shipit:

@DavidFair DavidFair referenced this pull request Mar 29, 2017

Merged

Enabled/VisibleWhenProperty - Multiple conditions #19264

5 of 9 tasks complete

@peterfpeterson peterfpeterson merged commit 88a9094 into master Mar 29, 2017

9 checks passed

ClangFormat Jenkins build pull_requests-clang-format 12411 has succeeded
Details
Doxygen Jenkins build pull_requests-doxygen 11750 has succeeded
Details
Flake8 Jenkins build pull_requests-flake8 3073 has succeeded
Details
OSX Jenkins build pull_requests-osx 12920 has succeeded
Details
RHEL7 + System Tests Jenkins build pull_requests-rhel7 12817 has succeeded
Details
Ubuntu + Doc Tests Jenkins build pull_requests-ubuntu 13414 has succeeded
Details
Ubuntu Python 3 Jenkins build pull_requests-ubuntu-python3 956 has succeeded
Details
Windows Jenkins build pull_requests-win7 13677 has succeeded
Details
cppcheck Jenkins build pull_requests-cppcheck 13399 has succeeded
Details

@peterfpeterson peterfpeterson deleted the 19232_fix_reflectometry_rst branch Mar 29, 2017

@PranavBahuguna PranavBahuguna moved this from Open PR to Done in ISIS Large Scale Structures Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment