Use std::make_unique with MSVC #19263

merged 3 commits into from Mar 31, 2017


None yet
3 participants

quantumsteve commented Mar 29, 2017

Description of work.

This updates Mantid::Kernel::make_unique to use std::make_unique with Visual Studio. Where possible, I also replaced typedef with the newer using syntax.

To test:

If the builds pass, :shipit:

There is no GitHub issue associated with this pull request.

Does not need to be in the release notes.


Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.


This comment has been minimized.

Show comment
Hide comment

OwenArnold Mar 31, 2017


Looks good :shipit:


OwenArnold commented Mar 31, 2017

Looks good :shipit:

@peterfpeterson peterfpeterson merged commit ec16f2c into master Mar 31, 2017

9 checks passed

ClangFormat Jenkins build pull_requests-clang-format 12435 has succeeded
Doxygen Jenkins build pull_requests-doxygen 11768 has succeeded
Flake8 Jenkins build pull_requests-flake8 3091 has succeeded
OSX Jenkins build pull_requests-osx 12953 has succeeded
RHEL7 + System Tests Jenkins build pull_requests-rhel7 12836 has succeeded
Ubuntu + Doc Tests Jenkins build pull_requests-ubuntu 13431 has succeeded
Ubuntu Python 3 Jenkins build pull_requests-ubuntu-python3 974 has succeeded
Windows Jenkins build pull_requests-win7 13699 has succeeded
cppcheck Jenkins build pull_requests-cppcheck 13424 has succeeded

@peterfpeterson peterfpeterson deleted the make_unique branch Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment