Fix coverity issue #19269

Merged
merged 3 commits into from Mar 31, 2017

Conversation

Projects
None yet
3 participants
@peterfpeterson
Member

peterfpeterson commented Mar 30, 2017

Check for a null pointer after a dynamic cast.

To test:

If the builds pass, it just a code review.

Fixes coverity issue 1373126

Does not need to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@peterfpeterson peterfpeterson added this to the Release 3.10 milestone Mar 30, 2017

@AndreiSavici AndreiSavici self-assigned this Mar 30, 2017

@AndreiSavici

This comment has been minimized.

Show comment
Hide comment
Member

AndreiSavici commented Mar 30, 2017

LGTM :shipit:

@NickDraper NickDraper merged commit 5faae4f into master Mar 31, 2017

9 checks passed

ClangFormat Jenkins build pull_requests-clang-format 12471 has succeeded
Details
Doxygen Jenkins build pull_requests-doxygen 11793 has succeeded
Details
Flake8 Jenkins build pull_requests-flake8 3117 has succeeded
Details
OSX Jenkins build pull_requests-osx 12989 has succeeded
Details
RHEL7 + System Tests Jenkins build pull_requests-rhel7 12862 has succeeded
Details
Ubuntu + Doc Tests Jenkins build pull_requests-ubuntu 13460 has succeeded
Details
Ubuntu Python 3 Jenkins build pull_requests-ubuntu-python3 1001 has succeeded
Details
Windows Jenkins build pull_requests-win7 13727 has succeeded
Details
cppcheck Jenkins build pull_requests-cppcheck 13453 has succeeded
Details

@NickDraper NickDraper deleted the Graph_nullptr branch Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment