Permalink
Commits on Dec 4, 2017
  1. svn: prevent hanging when reading output from pipes

    FSD-Christian-ISS committed with dregad Dec 4, 2017
    This occurs even on non-windows machines.
    
    Fixed by opening STDERR in append mode, as per
    http://php.net/manual/en/function.proc-open.php#97012
    
    Fixes #254
  2. Remove usage of non existent style.css

    atrol committed with dregad Dec 4, 2017
    The file was actually removed in 2813829 
    as part of the modern UI conversion.
    
    Fixes #257
Commits on Nov 13, 2017
  1. Remove unused code

    atrol committed with dregad Nov 12, 2017
Commits on Sep 20, 2017
  1. SourceSVN: add/update German translation

    obmsch committed with dregad Sep 19, 2017
    In addition to pr #247, e02794f
Commits on Sep 17, 2017
  1. Bump version to 2.1.0

    dregad committed Sep 17, 2017
    VCS plugins changes:
    - SourceCgit 2.0.1
    - SourceGithub 2.0.1
    - SourceGitlab 2.0.1
    - SourceGitphp 2.0.1
    - SourceGitweb 2.0.2
    - SourceHgWeb 2.1.0
    - SourceSVN 2.1.0
    - SourceWebSVN 2.0.1
  2. Add Changelog for 2.x releases

    dregad committed Sep 17, 2017
  3. Merge tag 'v1.5.4'

    dregad committed Sep 17, 2017
  4. Bump version to 1.5.4

    dregad committed Sep 17, 2017
    VCS plugins changes:
    - SourceHgWeb 1.1.0
    - SourceSVN 1.0.1
  5. Add Changelog and reference it in README file

    dregad committed Sep 17, 2017
    Detailed changelog for 1.x release following 'Keep a Changelog' format
    (http://keepachangelog.com/).
    
    Older (0.x) releases are just linked to Github's compare page.
Commits on Sep 16, 2017
  1. Improve error detection & handling when invoking SVN

    bright-tools committed with dregad Sep 16, 2017
    Move the call to plugin_push_current() to be before the first call
    to svn_binary() to ensure that svn_binary()'s calls to
    plugin_config_get() retrieve the options from SourceSVN's config
    options rather than any plugin inheriting from SourceSVN
    
    Fixes #247
  2. Doc: wrap long lines, tweaks

    dregad committed Sep 16, 2017
  3. Configuration guide for SourceSVN

    bright-tools committed with dregad Sep 16, 2017
    Add configuration guide for SourceSVN & link from README.md
    
    Fixes #250
  4. Merge branch 'master-1.3.x'

    dregad committed Sep 16, 2017
    # Conflicts:
    #	SourceHgWeb/SourceHgWeb.php
  5. HgWeb: refactoring commit_changeset() method

    dregad committed Sep 16, 2017
    A more robust implementation that processes the output from HgWeb's
    raw-rev output in several steps
    1. Skipping header section
    2. Retrieve changeset metadata (Author, Date, Revision and Parent ID)
    3. Get the commit message
    4. Information about updated files (add/rm/mod)
    
    Previously, steps 1-3 were performed in a single loop, which was causing
    issues depending on contents of the commit message, e.g. when a line
    starts with a `#` (see #233).
    
    Define regex patterns as class constants and use static vars to improve
    performance, code readability and avoid duplicating patterns.
    
    Add PHPDoc block.
    
    Fixes #233
  6. HgWeb: allow space and unicode chars in filename

    Zipher04 committed with dregad May 29, 2017
    Fixes #219
    
    Backported from c88bc43.
  7. HgWeb: fix uncaught error when url_get() fails

    dregad committed Sep 16, 2017
    url_get() returns null, not false, so the strict-type check performed
    after attempting to retrieve changeset data from HgWeb fails and code
    attempts to call commit_changeset() with no data, causing an SQL error.
    
    Removing strict-type check ensures the failed url_get() call is handled
    properly.
    
    Fixes #248
Commits on Sep 15, 2017
  1. Fix change of repo name after full import

    dregad committed Sep 15, 2017
    If a repository is imported successfully but import_full() does not
    actually return any changesets, the temp repo created for the import
    remains with its `Import <timestamp>` name instead of being renamed to
    the original repo's name, and the latter is deleted.
    
    Setting the temp repo's name right after the initial save operation
    prevents this unwanted behavior.
    
    Fixes #245
  2. Fix indentation

    dregad committed Sep 15, 2017
Commits on Sep 14, 2017
  1. Whitespace, break long line

    dregad committed Sep 14, 2017
  2. Show status color box next to issue id in view page

    dregad committed Sep 14, 2017
    The view page was not consistently formatting resolved issue IDs; a
    regular link was displayed in Attached Issues list, whereas if the same
    resolved/closed issue was referenced in the Changeset messages it would
    be printed with strikethrough ('resolved' CSS class).
    
    An attempt to fix this by using the same string_get_bug_view_link()
    function for the Affected Issues list was not looking good due to the
    tooltip with issue description (the same text is already displayed next
    to the issue id).
    
    Finally, displaying a box with the issue's status color (similar to the
    display in My View and View Issues pages) was implemented.
    
    Fixes #234
  3. Merge branch 'master-1.3.x'

    dregad committed Sep 14, 2017
  4. Remove extra '(select one)' in mapping strategy select

    dregad committed Sep 14, 2017
    Commit 34b1e6d refactored the
    display_strategies() function to store strategies in an array, and
    looping over that to generate the select's options, but an echo
    statement printing the 'select_one' entry was left out.
    
    Fixes #238
  5. Move plugin_push_current() before svn_binary() in svn_call()

    bright-tools committed with dregad Sep 14, 2017
    Move the call to plugin_push_current() to be before the first call
    to svn_binary() to ensure that svn_binary()'s calls to
    plugin_config_get() retrieve the options from SourceSVN's config
    options rather than any plugin inheriting from SourceSVN
    
    Fixes #242
    
    Backported from c88f88c
  6. Fix missing language string error

    dregad committed Sep 14, 2017
    When viewing an issue's Related Changesets (in view.php), an error
    message 'String "plugin_SourceIntegration_affected_issues" not found.'
    is displayed.
    
    This is because the plugin context in View Issue page is not 'Source',
    but 'SourceIntegration', so the plugin_lang_get() call needs to
    reference the base plugin.
    
    Regression introduced by 5aec110 (#224)
    
    Fixes #231
  7. Only display spacer row when necessary

    dregad committed Jun 16, 2017
    If there are no existing branch mappings, the spacer row is useless
    
    Fixes #244
  8. Disable 'branch' field except for new mapping

    dregad committed Jun 16, 2017
    Since the branch's name is used as key to identify the mapping, it is
    not possible to change it. To avoid confusing behavior, the input field
    is disabled, except for the new mapping row.
    
    Fixes #243
  9. Move plugin_push_current() before svn_binary() in svn_call()

    bright-tools committed with dregad Sep 14, 2017
    Move the call to plugin_push_current() to be before the first call
    to svn_binary() to ensure that svn_binary()'s calls to
    plugin_config_get() retrieve the options from SourceSVN's config
    options rather than any plugin inheriting from SourceSVN
    
    Fixes #242
  10. Merge branch 'hotfix/1.5.3'

    dregad committed Sep 14, 2017
    Conflicts:
    	Source/MantisSourceBase.class.php
    	SourceCgit/SourceCgit.php
    	SourceGithub/SourceGithub.php
    	SourceGitlab/SourceGitlab.php
    	SourceGitphp/SourceGitphp.php
    	SourceGitweb/SourceGitweb.php
    	SourceHgWeb/SourceHgWeb.php
Commits on Jun 26, 2017
  1. Improved handling of changesets on list page

    dregad committed Jun 26, 2017
    Merge pull request #224, fixes #202
  2. Redirect back to list page after linking issues

    dregad committed Jun 9, 2017
    Use changeset's revision id as anchor in the changesets list, and use
    that as a new 'redirect' parameter for the attach page so it returns
    straight to the changeset list's row that called it.
    
    If the new param is not specified, the behavior is as it was before,
    i.e. redirect to view page.
  3. Allow attaching issues from changeset list page

    dregad committed Jun 9, 2017
    If there are no issues linked to the changeset, display an input field
    and button to allow the user to add links without having to open the
    changeset view page.
Commits on Jun 14, 2017
  1. Use "plugin_lang_get_defaulted" to display repo settings keys,

    obmsch committed May 3, 2017
    trans bool values
    
    - conditionally add function "plugin_lang_get_defaulted" for
      the lookup in Source.API.php