Permalink
Browse files

bug_reminder.php does not handle unsent reminders

Reminders are not logged in history (or the bugnote) if the e-mail was not
actually sent to the recipient.

The function now uses email_bug_reminder()'s return value instead of the
full user-provided list of recipients for inclusion in the reminder's
bugnote and to add history entries.

Fixes #15471
  • Loading branch information...
1 parent 389b2a6 commit 15db187cf65e6fd323e7c65b25965d38841467db @dregad dregad committed Feb 7, 2013
Showing with 2 additions and 2 deletions.
  1. +2 −2 bug_reminder.php
View
@@ -101,7 +101,7 @@
# Build list of recipients, truncated to note_attr fields's length
$t_attr = '|';
$t_length = 0;
- foreach( $f_to as $t_id ) {
+ foreach( $result as $t_id ) {
$t_recipient = $t_id . '|';
$t_length += strlen( $t_recipient );
if( $t_length > 250 ) {
@@ -115,7 +115,7 @@
}
# Add history entries for all sent reminders
-foreach ( $f_to as $t_recipient ) {
+foreach ( $result as $t_recipient ) {
history_log_event_special( $f_bug_id, BUG_REMINDER_SENT, $t_recipient );
}

0 comments on commit 15db187

Please sign in to comment.