Skip to content

Commit a2d90ec

Browse files
committed
Fix XSS in bug_change_status_page.php
The value of the change_type parameter was not encoded before being displayed as a hidden input. This vulnerability was reported by Etienne Landais. Fixes #22486
1 parent 23da4e0 commit a2d90ec

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: bug_change_status_page.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@
154154
<input type="hidden" name="bug_id" value="<?php echo $f_bug_id ?>" />
155155
<input type="hidden" name="status" value="<?php echo $f_new_status ?>" />
156156
<input type="hidden" name="last_updated" value="<?php echo $t_bug->last_updated ?>" />
157-
<input type="hidden" name="action_type" value="<?php echo $f_change_type; ?>" />
157+
<input type="hidden" name="action_type" value="<?php echo string_attribute( $f_change_type ); ?>" />
158158

159159
<?php
160160
$t_current_resolution = $t_bug->resolution;

0 commit comments

Comments
 (0)