Skip to content
Browse files

Fix #0016570: Page content is forgotten when user clicks [Back] button

By default we disable $g_allow_browser_cache in all circumstances.

The config value is commented out in config_defaults.inc.php. In fact, thraxisp
added the config option in 2005 in the commented out state.

It would appear the DHX re-ordered this call when implemented require_api
- see:

 2d5455c

The above code is only in 1.3 and not in the 1.2 series, so the above fix should
be safe to apply.

We probably need to consider whether we actually want to remove this configuration option

After all, it's a configuration option we've probably never had anyone use in 5 years
so I expect that the value of it is rather....
  • Loading branch information...
1 parent 13c2096 commit d508493ab34190b7647b8b644548a565c0fc664e @grangeway grangeway committed
Showing with 6 additions and 6 deletions.
  1. +2 −2 bug_change_status_page.php
  2. +2 −2 bug_report_page.php
  3. +2 −2 bug_update_page.php
View
4 bug_change_status_page.php
@@ -41,6 +41,8 @@
* @uses version_api.php
*/
+$g_allow_browser_cache = 1;
+
require_once( 'core.php' );
require_api( 'access_api.php' );
require_api( 'authentication_api.php' );
@@ -60,8 +62,6 @@
require_api( 'sponsorship_api.php' );
require_api( 'version_api.php' );
-$g_allow_browser_cache = 1;
-
$f_bug_id = gpc_get_int( 'id' );
$t_bug = bug_get( $f_bug_id );
View
4 bug_report_page.php
@@ -49,6 +49,8 @@
* @uses version_api.php
*/
+$g_allow_browser_cache = 1;
+
require_once( 'core.php' );
require_api( 'access_api.php' );
require_api( 'authentication_api.php' );
@@ -75,8 +77,6 @@
require_api( 'utility_api.php' );
require_api( 'version_api.php' );
-$g_allow_browser_cache = 1;
-
$f_master_bug_id = gpc_get_int( 'm_id', 0 );
if( $f_master_bug_id > 0 ) {
View
4 bug_update_page.php
@@ -46,6 +46,8 @@
* @uses version_api.php
*/
+$g_allow_browser_cache = 1;
+
require_once( 'core.php' );
require_api( 'access_api.php' );
require_api( 'authentication_api.php' );
@@ -71,8 +73,6 @@
require_css( 'status_config.php' );
-$g_allow_browser_cache = 1;
-
$f_bug_id = gpc_get_int( 'bug_id' );
$t_bug = bug_get( $f_bug_id, true );

0 comments on commit d508493

Please sign in to comment.
Something went wrong with that request. Please try again.