From d98fe4251ebd6e68815cb22a7e2b0bfb06673024 Mon Sep 17 00:00:00 2001
From: Damien Regad <dregad@mantisbt.org>
Date: Fri, 4 Sep 2020 19:09:30 +0200
Subject: [PATCH] Add <label> to form inputs

To comply with WCAG standard, inputs should be associated with a label.

This requires a CSS tweak CSS to ensure consistent display of labels in
bold font.

Fixes #27258
---
 account_prof_edit_page.php | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/account_prof_edit_page.php b/account_prof_edit_page.php
index af0950d596..e7a7db1ca9 100644
--- a/account_prof_edit_page.php
+++ b/account_prof_edit_page.php
@@ -115,11 +115,13 @@
 						<table class="table table-striped table-bordered table-condensed">
 							<tr>
 								<th class="category">
-									<span class="required">*</span>
-									<?php echo lang_get( 'platform' ) ?>
+									<label for="platform">
+										<span class="required">*</span>
+										<?php echo lang_get( 'platform' ) ?>
+									</label>
 								</th>
 								<td>
-									<input name="platform" type="text" required
+									<input id="platform" name="platform" type="text" required
 										   class="input-sm" size="32" maxlength="32"
 										   value="<?php echo string_attribute( $v_platform ) ?>"
 									/>
@@ -127,11 +129,13 @@ class="input-sm" size="32" maxlength="32"
 							</tr>
 							<tr>
 								<th class="category">
-									<span class="required">*</span>
-									<?php echo lang_get( 'os' ) ?>
+									<label for="os">
+										<span class="required">*</span>
+										<?php echo lang_get( 'os' ) ?>
+									</label>
 								</th>
 								<td>
-									<input name="os" type="text" required
+									<input id="os" name="os" type="text" required
 										   class="input-sm" size="32" maxlength="32"
 										   value="<?php echo string_attribute( $v_os ) ?>"
 									/>
@@ -139,11 +143,13 @@ class="input-sm" size="32" maxlength="32"
 							</tr>
 							<tr>
 								<th class="category">
-									<span class="required">*</span>
-									<?php echo lang_get( 'os_build' ) ?>
+									<label for="os_build">
+										<span class="required">*</span>
+										<?php echo lang_get( 'os_build' ) ?>
+									</label>
 								</th>
 								<td>
-									<input name="os_build" type="text" required
+									<input id="os_build" name="os_build" type="text" required
 										   class="input-sm" size="16" maxlength="16"
 										   value="<?php echo string_attribute( $v_os_build ) ?>"
 									/>
@@ -151,11 +157,13 @@ class="input-sm" size="16" maxlength="16"
 							</tr>
 							<tr>
 								<th class="category">
-									<?php echo lang_get( 'additional_description' ) ?>
+									<label for="description">
+										<?php echo lang_get( 'additional_description' ) ?>
+									</label>
 								</th>
 								<td>
 									<?php # Newline after opening textarea tag is intentional, see #25839 ?>
-									<textarea name="description"
+									<textarea id="description" name="description"
 											  class="form-control"
 											  cols="60" rows="8">
 <?php echo string_textarea( $v_description ) ?>