Permalink
Browse files

.

  • Loading branch information...
1 parent 2fbec66 commit ee1b1c959ff4cf8458aa901fdbe6c13e0571a9b8 @grangeway grangeway committed Jul 10, 2014
Showing with 1,947 additions and 2,090 deletions.
  1. +1 −1 account_prof_update.php
  2. +7 −8 account_sponsor_page.php
  3. +16 −16 adm_config_report.php
  4. +9 −9 adm_config_set.php
  5. +1 −1 admin/check/check_api.php
  6. +1 −1 admin/check/check_database_inc.php
  7. +2 −2 admin/check/check_integrity_inc.php
  8. +3 −3 admin/check/check_paths_inc.php
  9. +1 −1 admin/db_stats.php
  10. +4 −4 admin/email_queue.php
  11. +13 −13 admin/install.php
  12. +5 −5 admin/move_attachments.php
  13. +1 −1 admin/schema.php
  14. +1 −1 admin/test_icons.php
  15. +4 −4 admin/test_langs.php
  16. +9 −9 admin/upgrade_unattended.php
  17. +1 −2 admin/upgrade_warning.php
  18. +1 −1 api/soap/mantisconnect.php
  19. +5 −5 api/soap/mc_api.php
  20. +2 −2 api/soap/mc_config_api.php
  21. +14 −21 api/soap/mc_file_api.php
  22. +11 −11 api/soap/mc_issue_api.php
  23. +14 −14 api/soap/mc_project_api.php
  24. +1 −1 api/soap/mc_tag_api.php
  25. +5 −5 billing_inc.php
  26. +178 −193 bug_actiongroup.php
  27. +3 −20 bug_actiongroup_page.php
  28. +3 −3 bug_monitor_list_view_inc.php
  29. +1 −2 bug_relationship_add.php
  30. +2 −2 bug_relationship_graph.php
  31. +2 −2 bug_report.php
  32. +3 −3 bug_report_page.php
  33. +2 −2 bug_sponsorship_list_view_inc.php
  34. +2 −2 bug_update.php
  35. +1 −1 bug_update_page.php
  36. +2 −2 bug_view_inc.php
  37. +1 −1 bugnote_edit_page.php
  38. +7 −11 bugnote_stats_inc.php
  39. +4 −4 bugnote_view_inc.php
  40. +12 −12 changelog_page.php
  41. +2 −2 core.php
  42. +2 −4 core/access_api.php
  43. +4 −5 core/authentication_api.php
  44. +77 −84 core/bug_api.php
  45. +19 −33 core/bug_revision_api.php
  46. +31 −40 core/bugnote_api.php
  47. +27 −28 core/category_api.php
  48. +1 −1 core/cfdefs/cfdef_standard.php
  49. +64 −64 core/classes/MantisEnum.class.php
  50. +1 −1 core/collapse_api.php
  51. +2 −2 core/columns_api.php
  52. +16 −22 core/config_api.php
  53. +2 −2 core/constant_inc.php
  54. +2 −2 core/crypto_api.php
  55. +1 −1 core/custom_field_api.php
  56. +25 −29 core/database_api.php
  57. +19 −23 core/date_api.php
  58. +2 −3 core/email_api.php
  59. +1 −1 core/email_queue_api.php
  60. +7 −8 core/error_api.php
  61. +5 −5 core/excel_api.php
  62. +33 −36 core/file_api.php
  63. +56 −66 core/filter_api.php
  64. +6 −10 core/gpc_api.php
  65. +4 −6 core/graphviz_api.php
  66. +7 −7 core/html_api.php
  67. +1 −1 core/icon_api.php
  68. +9 −9 core/install_helper_functions_api.php
  69. +1 −2 core/lang_api.php
  70. +21 −21 core/ldap_api.php
  71. +5 −5 core/logging_api.php
  72. +22 −22 core/news_api.php
  73. +1 −2 core/php_api.php
  74. +3 −6 core/plugin_api.php
  75. +16 −17 core/print_api.php
  76. +7 −7 core/profile_api.php
  77. +19 −20 core/project_api.php
  78. +5 −5 core/project_hierarchy_api.php
  79. +10 −10 core/relationship_api.php
  80. +1 −1 core/rss_api.php
  81. +1 −1 core/session_api.php
  82. +10 −10 core/sponsorship_api.php
  83. +4 −4 core/string_api.php
  84. +14 −19 core/summary_api.php
  85. +9 −9 core/tag_api.php
  86. +7 −7 core/timeline_api.php
  87. +7 −7 core/tokens_api.php
  88. +23 −25 core/user_api.php
  89. +9 −9 core/user_pref_api.php
  90. +49 −52 core/version_api.php
  91. +1 −1 docbook/Admin_Guide/en-US/Customizing.xml
  92. +5 −5 docbook/Admin_Guide/en-US/Project_Management.xml
  93. +2 −2 docbook/Developers_Guide/en-US/Plugins_Building.xml
  94. +2 −2 docbook/Developers_Guide/en-US/Plugins_Building_Source.xml
  95. +1 −1 excel_xml_export.php
  96. +5 −4 file_download.php
  97. +39 −39 issues_rss.php
  98. +1 −1 library/adodb
  99. +2 −2 login_anon.php
  100. +4 −5 login_page.php
  101. +3 −3 main_page.php
  102. +16 −15 manage_config_email_page.php
  103. +56 −59 manage_config_work_threshold_page.php
  104. +14 −15 manage_config_work_threshold_set.php
  105. +31 −31 manage_config_workflow_page.php
  106. +1 −1 manage_config_workflow_set.php
  107. +8 −1 manage_custom_field_edit_page.php
  108. +2 −2 manage_plugin_page.php
  109. +6 −4 manage_plugin_update.php
  110. +2 −3 manage_proj_cat_delete.php
  111. +10 −10 manage_proj_edit_page.php
  112. +6 −6 manage_proj_page.php
  113. +5 −5 manage_tags_page.php
  114. +4 −2 manage_user_create_page.php
  115. +25 −22 manage_user_page.php
  116. +6 −7 manage_user_prune.php
  117. +10 −10 manage_user_update.php
  118. +38 −38 my_view_inc.php
  119. +6 −9 my_view_page.php
  120. +2 −3 news_list_page.php
  121. +3 −3 news_rss.php
  122. +1 −1 news_update.php
  123. +1 −1 permalink_page.php
  124. +7 −7 plugins/MantisGraph/core/Period.php
  125. +85 −104 plugins/MantisGraph/core/graph_api.php
  126. +6 −6 plugins/MantisGraph/pages/bug_graph_bycategory.php
  127. +4 −4 plugins/MantisGraph/pages/bug_graph_bystatus.php
  128. +7 −7 plugins/MantisGraph/pages/config.php
  129. +1 −1 plugins/MantisGraph/pages/config_edit.php
  130. +2 −2 plugins/MantisGraph/pages/summary_jpgraph_page.php
  131. +13 −13 plugins/XmlImportExport/ImportXml.php
  132. +40 −42 plugins/XmlImportExport/ImportXml/Issue.php
  133. +1 −1 plugins/XmlImportExport/pages/export.php
  134. +1 −1 plugins/XmlImportExport/pages/import.php
  135. +33 −28 print_all_bug_options_inc.php
  136. +1 −3 print_all_bug_options_reset.php
  137. +1 −3 print_all_bug_options_update.php
  138. +6 −6 print_all_bug_page.php
  139. +3 −3 print_all_bug_page_word.php
  140. +5 −5 print_bug_page.php
  141. +104 −105 print_bugnote_inc.php
  142. +1 −1 proj_doc_delete.php
  143. +1 −1 proj_doc_edit_page.php
  144. +15 −16 proj_doc_page.php
  145. +8 −8 proj_doc_update.php
  146. +7 −7 project_page.php
  147. +9 −10 query_delete.php
  148. +1 −1 query_store_page.php
  149. +3 −3 query_view_page.php
  150. +5 −5 return_dynamic_filters.php
  151. +9 −9 roadmap_page.php
  152. +2 −2 set_project.php
  153. +1 −1 signup.php
  154. +3 −3 signup_page.php
  155. +6 −6 summary_page.php
  156. +1 −1 tag_attach.php
  157. +1 −2 tag_update.php
  158. +1 −2 tag_update_page.php
  159. +1 −1 tag_view_page.php
  160. +5 −5 tests/TestConfig.php
  161. +3 −3 tests/soap/AttachmentTest.php
  162. +16 −18 tests/soap/FilterTest.php
  163. +10 −10 tests/soap/IssueAddTest.php
  164. +5 −5 tests/soap/IssueNoteTest.php
  165. +5 −5 tests/soap/IssueUpdateTest.php
  166. +10 −10 tests/soap/LoginTest.php
  167. +3 −3 tests/soap/ProjectTest.php
  168. +3 −3 tests/soap/TagTest.php
  169. +2 −2 tests/test_config_get_set.php
  170. +1 −1 verify.php
  171. +2 −3 view_all_inc.php
  172. +110 −112 view_all_set.php
  173. +31 −17 view_filters_page.php
  174. +1 −1 view_user_page.php
  175. +2 −2 xmlhttprequest.php
View
@@ -68,7 +68,7 @@
}
}
-switch ( $f_action ) {
+switch( $f_action ) {
case 'edit':
form_security_purge( 'profile_update' );
print_header_redirect( 'account_prof_edit_page.php?profile_id=' . $f_profile_id );
View
@@ -115,12 +115,12 @@
$t_project_clause = helper_project_specific_where( $t_project );
-$t_query = "SELECT b.id as bug, s.id as sponsor, s.paid, b.project_id, b.fixed_in_version, b.status
- FROM $t_bug_table b, $t_sponsor_table s
- WHERE s.user_id=" . db_param() . " AND s.bug_id = b.id " .
- ( $t_show_all ? '' : 'AND ( b.status < ' . db_param() . ' OR s.paid < ' . SPONSORSHIP_PAID . ')' ) . "
- AND $t_project_clause
- ORDER BY s.paid ASC, b.project_id ASC, b.fixed_in_version ASC, b.status ASC, b.id DESC";
+$t_query = 'SELECT b.id as bug, s.id as sponsor, s.paid, b.project_id, b.fixed_in_version, b.status
+ FROM ' . $t_bug_table . ' b, ' . $t_sponsor_table . ' s
+ WHERE s.user_id=' . db_param() . ' AND s.bug_id = b.id ' .
+ ( $t_show_all ? '' : 'AND ( b.status < ' . db_param() . ' OR s.paid < ' . SPONSORSHIP_PAID . ')' ) . '
+ AND ' . $t_project_clause . '
+ ORDER BY s.paid ASC, b.project_id ASC, b.fixed_in_version ASC, b.status ASC, b.id DESC';
$t_result = db_query_bound( $t_query, $t_show_all ? array( $t_user ) : array( $t_user , $t_resolved ) );
@@ -139,7 +139,6 @@
<br />
<div>
<table class="width100" cellspacing="1">
-
<!-- Headings -->
<tr>
<td class="form-title" colspan="9">
@@ -233,7 +232,7 @@
$t_query = "SELECT b.id as bug, s.id as sponsor, s.paid, b.project_id, b.fixed_in_version, b.status
FROM $t_bug_table b, $t_sponsor_table s
- WHERE b.handler_id=" . db_param() . " AND s.bug_id = b.id " .
+ WHERE b.handler_id=" . db_param() . ' AND s.bug_id = b.id ' .
( $t_show_all ? '' : 'AND ( b.status < ' . db_param() . ' OR s.paid < ' . SPONSORSHIP_PAID . ')' ) . "
AND $t_project_clause
ORDER BY s.paid ASC, b.project_id ASC, b.fixed_in_version ASC, b.status ASC, b.id DESC";
View
@@ -106,7 +106,7 @@ function print_config_value_as_string( $p_type, $p_value, $p_for_display = true
case CONFIG_TYPE_STRING:
$t_value = string_nl2br( string_html_specialchars( config_eval( $p_value ) ) );
if( $p_for_display ) {
- $t_value = '<p id="adm-config-value">' . "'$t_value'" . '</p>';
+ $t_value = '<p id="adm-config-value">\'' . $t_value . '\'</p>';
}
echo $t_value;
return;
@@ -142,9 +142,9 @@ function print_config_value_as_string( $p_type, $p_value, $p_for_display = true
*/
function print_option_list_from_array( array $p_array, $p_filter_value ) {
foreach( $p_array as $t_key => $t_value ) {
- echo "<option value='$t_key'";
+ echo '<option value="' . $t_key . '"';
check_selected( (string)$p_filter_value, (string)$t_key );
- echo '>' . string_attribute( $t_value ) . "</option>\n";
+ echo '>' . string_attribute( $t_value ) . '</option>' . "\n";
}
}
@@ -258,19 +258,19 @@ function print_option_list_from_array( array $p_array, $p_filter_value ) {
$t_where = '';
$t_param = array();
if( $t_filter_user_value != META_FILTER_NONE ) {
- $t_where .= " AND user_id = " . db_param();
+ $t_where .= ' AND user_id = ' . db_param();
$t_param[] = $t_filter_user_value;
}
if( $t_filter_project_value != META_FILTER_NONE ) {
- $t_where .= " AND project_id = " . db_param();
+ $t_where .= ' AND project_id = ' . db_param();
$t_param[] = $t_filter_project_value;
}
if( $t_filter_config_value != META_FILTER_NONE ) {
- $t_where .= " AND config_id = " . db_param();
+ $t_where .= ' AND config_id = ' . db_param();
$t_param[] = $t_filter_config_value;
}
if( $t_where != '' ) {
- $t_where = " WHERE 1=1 " . $t_where;
+ $t_where = ' WHERE 1=1 ' . $t_where;
}
$t_query = "SELECT config_id, user_id, project_id, type, value, access_reqd
@@ -313,23 +313,23 @@ function print_option_list_from_array( array $p_array, $p_filter_value ) {
<tr class="row-1">
<td>
<select name="filter_user_id">
- <?php
- print_option_list_from_array( $t_users_list, $t_filter_user_value );
- ?>
+ <?php
+ print_option_list_from_array( $t_users_list, $t_filter_user_value );
+ ?>
</select>
</td>
<td>
<select name="filter_project_id">
- <?php
- print_option_list_from_array( $t_projects_list, $t_filter_project_value );
- ?>
+ <?php
+ print_option_list_from_array( $t_projects_list, $t_filter_project_value );
+ ?>
</select>
</td>
<td>
<select name="filter_config_id">
- <?php
- print_option_list_from_array( $t_configs_list, $t_filter_config_value );
- ?>
+ <?php
+ print_option_list_from_array( $t_configs_list, $t_filter_config_value );
+ ?>
</select>
</td>
</tr>
View
@@ -165,7 +165,7 @@ function process_complex_value( $p_value, $p_trimquotes = false ) {
')';
}
- if( preg_match( "/$s_regex_array/s", $t_value, $t_match ) === 1 ) {
+ if( preg_match( '/' . $s_regex_array . '/s', $t_value, $t_match ) === 1 ) {
# It's an array - process each element
$t_processed = array();
@@ -176,7 +176,7 @@ function process_complex_value( $p_value, $p_trimquotes = false ) {
continue;
}
# Check if element is associative array
- preg_match_all( "/($s_regex_string)\s*=>\s*(.*)/", $t_element, $t_split );
+ preg_match_all( '/(' . $s_regex_string . ')\s*=>\s*(.*)/', $t_element, $t_split );
if( !empty( $t_split[0] ) ) {
# associative array
$t_new_key = constant_replace( trim( $t_split[1][0], " \t\n\r\0\x0B\"'" ) );
@@ -207,7 +207,7 @@ function process_complex_value( $p_value, $p_trimquotes = false ) {
*/
function special_split ( $p_string ) {
$t_values = array();
- $t_array_element = "";
+ $t_array_element = '';
$t_paren_level = 0;
$t_inside_quote = false;
$t_escape_next = false;
@@ -216,17 +216,17 @@ function special_split ( $p_string ) {
if( $t_escape_next ) {
$t_array_element .= $t_character;
$t_escape_next = false;
- } else if( $t_character == "," && $t_paren_level==0 && !$t_inside_quote ) {
+ } else if( $t_character == ',' && $t_paren_level==0 && !$t_inside_quote ) {
array_push( $t_values, $t_array_element );
- $t_array_element = "";
+ $t_array_element = '';
} else {
- if( $t_character == "(" && !$t_inside_quote ) {
+ if( $t_character == '(' && !$t_inside_quote ) {
$t_paren_level++;
- } else if( $t_character == ")" && !$t_inside_quote ) {
+ } else if( $t_character == ')' && !$t_inside_quote ) {
$t_paren_level--;
- } else if( $t_character == "'" ) {
+ } else if( $t_character == '\'' ) {
$t_inside_quote = !$t_inside_quote;
- } else if( $t_character == "\\" ) {
+ } else if( $t_character == '\\' ) {
# escape character
$t_escape_next = true;
# keep the escape if the string will be going through another recursion
@@ -169,7 +169,7 @@ function check_print_info_row( $p_description, $p_info = null ) {
*/
function check_print_test_result( $p_result ) {
global $g_alternate_row, $g_failed_test, $g_passed_test_with_warnings;
- switch ( $p_result ) {
+ switch( $p_result ) {
case BAD:
echo "\t\t<td class=\"fail$g_alternate_row\">FAIL</td>\n";
$g_failed_test = true;
@@ -57,7 +57,7 @@
check_print_test_row(
'Checking use of the <a href="http://adodb.sourceforge.net/#extension">ADOdb extension</a>',
!extension_loaded( 'ADOdb' ),
- "The ADOdb extension is not supported and must be disabled"
+ 'The ADOdb extension is not supported and must be disabled'
);
}
check_print_test_row(
@@ -134,13 +134,13 @@ function check_file_integrity_recursive( $p_directory, $p_base_directory, $p_rel
if( $t_release !== null ) {
$t_integrity_ok = true;
$t_release_sanitised = htmlentities( $t_release );
- $t_integrity_info = "Matches file from release <a href=\"http://git.mantisbt.org/?p=mantisbt.git;a=commit;h=release-$t_release_sanitised\">$t_release_sanitised</a>.";
+ $t_integrity_info = 'Matches file from release <a href="http://git.mantisbt.org/?p=mantisbt.git;a=commit;h=release-' . $t_release_sanitised . '">' . $t_release_sanitised . '</a>.';
} else {
$t_commit = get_commit_containing_object_hash( $t_file_relative, $t_file_hash );
if( $t_commit !== null ) {
$t_integrity_ok = true;
$t_commit_sanitised = htmlentities( $t_commit );
- $t_integrity_info = "Matches file introduced or modified in commit <a href=\"http://git.mantisbt.org/?p=mantisbt.git;a=commit;h=$t_commit_sanitised\">$t_commit_sanitised</a>.";
+ $t_integrity_info = 'Matches file introduced or modified in commit <a href="http://git.mantisbt.org/?p=mantisbt.git;a=commit;h=' . $t_commit_sanitised . '">' . $t_commit_sanitised . '</a>.';
}
}
check_print_test_warn_row(
@@ -65,8 +65,8 @@
$t_path_config_name . ' configuration option has a trailing directory separator',
substr( $t_path['config_value'], -1, 1 ) == DIRECTORY_SEPARATOR,
array( false =>
- "You must provide a trailing directory separator (" . DIRECTORY_SEPARATOR .
- ") to the end of '" . htmlspecialchars( $t_path['config_value'] ) . "'."
+ 'You must provide a trailing directory separator (' . DIRECTORY_SEPARATOR .
+ ') to the end of \'' . htmlspecialchars( $t_path['config_value'] ) . '\'.'
)
);
}
@@ -133,7 +133,7 @@
}
check_print_test_warn_row(
$t_moveable_path . ' configuration option is set to a path outside the web root',
- !preg_match( "/^$t_absolute_path_regex_safe/", $t_moveable_real_path ),
+ !preg_match( '/^' . $t_absolute_path_regex_safe . '/', $t_moveable_real_path ),
array( false => 'For increased security it is recommended that you move the ' . $t_moveable_path . ' directory outside the web root.' )
);
}
View
@@ -51,7 +51,7 @@ function print_info_row( $p_description, $p_value ) {
*/
function helper_table_row_count( $p_table ) {
$t_table = $p_table;
- $t_query = "SELECT COUNT(*) FROM $t_table";
+ $t_query = 'SELECT COUNT(*) FROM ' . $t_table;
$t_result = db_query_bound( $t_query );
$t_count = db_result( $t_result );
View
@@ -34,13 +34,13 @@
if( $f_to !== null ) {
if( $f_to == 'all' ) {
- echo "Sending emails...<br />";
+ echo 'Sending emails...<br />';
email_send_all();
- echo "Done";
+ echo 'Done';
} else if( $f_to == 'sendordelall' ) {
- echo "Sending or deleting emails...<br />";
+ echo 'Sending or deleting emails...<br />';
email_send_all( true );
- echo "Done";
+ echo 'Done';
} else {
$t_email_data = email_queue_get( (int)$f_to );
View
@@ -114,26 +114,26 @@ function print_test( $p_test_description, $p_result, $p_hard_fail = true, $p_mes
<?php
switch( $t_install_state ) {
case 6:
- echo "Post Installation Checks";
+ echo 'Post Installation Checks';
break;
case 5:
- echo "Install Configuration File";
+ echo 'Install Configuration File';
break;
case 4:
- echo "Additional Configuration Information";
+ echo 'Additional Configuration Information';
break;
case 3:
- echo "Install Database";
+ echo 'Install Database';
break;
case 2:
- echo "Check and Install Database";
+ echo 'Check and Install Database';
break;
case 1:
- echo "Database Parameters";
+ echo 'Database Parameters';
break;
case 0:
default:
- echo "Pre-Installation Check";
+ echo 'Pre-Installation Check';
break;
}
?>
@@ -215,7 +215,7 @@ function print_test( $p_test_description, $p_result, $p_hard_fail = true, $p_mes
if( $t_config_exists ) {
if( 0 == $t_install_state ) {
- print_test( "Config File Exists - Upgrade", true );
+ print_test( 'Config File Exists - Upgrade', true );
print_test( 'Setting Database Type', '' !== $f_db_type, true, 'database type is blank?' );
@@ -316,7 +316,7 @@ function print_test( $p_test_description, $p_result, $p_hard_fail = true, $p_mes
# PostgreSQL, Oracle and MSSQL require at least 5.19. MySQL should be fine
# with 5.10 but to simplify we align to the requirement of the others.
$t_adodb_version = substr( $ADODB_vers, 1, strpos( $ADODB_vers, ' ' ) - 1 );
- print_test( "Checking ADOdb Library version is at least " . DB_MIN_VERSION_ADODB,
+ print_test( 'Checking ADOdb Library version is at least ' . DB_MIN_VERSION_ADODB,
version_compare( $t_adodb_version, DB_MIN_VERSION_ADODB, '>=' ),
true,
'Current version: ' . $ADODB_vers
@@ -695,7 +695,7 @@ function print_test( $p_test_description, $p_result, $p_hard_fail = true, $p_mes
if( $f_db_type == 'db2' ) {
$t_rs = $g_db->Execute( "select * from SYSIBM.SCHEMATA WHERE SCHEMA_NAME = '" . $f_db_schema . "' AND SCHEMA_OWNER = '" . $f_db_username . "'" );
if( $t_rs === false ) {
- echo "<br />false";
+ echo '<br />false';
}
if( $t_rs->EOF ) {
@@ -719,7 +719,7 @@ function print_test( $p_test_description, $p_result, $p_hard_fail = true, $p_mes
$t_dict = NewDataDictionary( $g_db );
if( $f_db_type == 'db2' ) {
- $t_rs = $g_db->Execute( "CREATE SCHEMA " . $f_db_schema );
+ $t_rs = $g_db->Execute( 'CREATE SCHEMA ' . $f_db_schema );
if( !$t_rs ) {
$t_result = false;
@@ -927,9 +927,9 @@ function print_test( $p_test_description, $p_result, $p_hard_fail = true, $p_mes
foreach( $t_sqlarray as $sql ) {
# "CREATE OR REPLACE TRIGGER" statements must end with "END;\n/" for Oracle sqlplus
if( $f_db_type == 'oci8' && stripos( $sql, 'CREATE OR REPLACE TRIGGER' ) === 0 ) {
- $t_sql_end = PHP_EOL . "/";
+ $t_sql_end = PHP_EOL . '/';
} else {
- $t_sql_end = ";";
+ $t_sql_end = ';';
}
echo htmlentities( $sql ) . $t_sql_end . PHP_EOL . PHP_EOL;
}
View
@@ -51,8 +51,8 @@ function move_attachments_to_disk( $p_type, array $p_projects ) {
$t_query = "SELECT f.*
FROM $t_file_table f
WHERE content <> ''
- AND f.project_id = " . db_param() . "
- ORDER BY f.filename";
+ AND f.project_id = " . db_param() . '
+ ORDER BY f.filename';
break;
case 'bug':
@@ -62,8 +62,8 @@ function move_attachments_to_disk( $p_type, array $p_projects ) {
FROM $t_file_table f
JOIN $t_bug_table b ON b.id = f.bug_id
WHERE content <> ''
- AND b.project_id = " . db_param() . "
- ORDER BY f.bug_id, f.filename";
+ AND b.project_id = " . db_param() . '
+ ORDER BY f.bug_id, f.filename';
break;
}
@@ -103,7 +103,7 @@ function move_attachments_to_disk( $p_type, array $p_projects ) {
# successful, update database
# @todo do we want to check the size of data transfer matches here?
$t_update_query = "UPDATE $t_file_table
- SET diskfile = " . db_param() . ", folder = " . db_param() . ", content = ''
+ SET diskfile = " . db_param() . ', folder = ' . db_param() . ", content = ''
WHERE id = " . db_param();
$t_update_result = db_query_bound( $t_update_query, array( $t_filename, $t_upload_path, $t_row['id'] ) );
View
@@ -58,7 +58,7 @@ function installer_db_now() {
# - Oci uses a different date literal syntax
# - Default BLOBs to empty_blob() function
if( db_is_oracle() ) {
- $t_notnull = "";
+ $t_notnull = '';
$t_timestamp = "timestamp" . installer_db_now();
$t_blob_default = 'DEFAULT " empty_blob() "';
} else {
View
@@ -31,7 +31,7 @@
foreach( $g_file_type_icons as $t_ext => $t_filename ) {
$t_file_path = dirname( dirname( __FILE__ ) ) . DIRECTORY_SEPARATOR . 'images' . DIRECTORY_SEPARATOR . 'fileicons' . DIRECTORY_SEPARATOR . $t_filename;
- echo "Testing icon for extension '$t_ext'... $t_file_path ... ";
+ echo 'Testing icon for extension \'' . $t_ext . '\'... ' . $t_file_path . '... ';
flush();
if( file_exists( $t_file_path ) ) {
Oops, something went wrong.

1 comment on commit ee1b1c9

Member

atrol commented on ee1b1c9 Jul 14, 2014

File manage_config_work_set_threshold.php function set_capability_row line 105
Should be $g_project instead of $t_project

Please sign in to comment.