Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
REST and SOAP API Improvements #1100
It is recommended to review this PR one commit at a time to follow the chain of changes.
SOAP and REST
Test cases look good at a first glance to me ( did not test ).
Have you considered sharing the test cases between the SOAP API and the REST API, while leaving the test setup separated? That would quickly increase the coverage of the REST API and we would only maintain one test suite in the future.
In the areas in which the two APIs differ - e.g. SOAP API not getting new features - we can easily find a way to only run some checks for one of the APIs.
@rombert Thanks for the review.
I haven't considered sharing test cases and I'm not in favor of it for the following reasons: