Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#19302: Free text search should match against tags, custom-fields,... #1140

Closed
wants to merge 1 commit into from

Conversation

@hloehnert
Copy link

commented Aug 5, 2017

http://www.mantisbt.org/bugs/view.php?id=19302

Text search extended for tags, custom-fields, category.

@atrol

This comment has been minimized.

Copy link

commented on 6d7182d Aug 5, 2017

@hloehnert, did you make some performance tests?
I would expect bad performance, especially if there are a lot of entries in table custom_field_string.

@hloehnert

This comment has been minimized.

Copy link
Author

commented Aug 7, 2017

My database contains following entries:
bug: 67527
bugnote: 23533
bug_tag: 1832
custom_field_string: 63115

The view-issue-page-execution-time is ~0.15 sec with activated text-search and 4 hits.
So I can't see a measurable impact caused by the additional joins.

@atrol

This comment has been minimized.

Copy link
Member

commented Aug 7, 2017

bug: 67527

Did you try with Hide Status = None ?

@hloehnert

This comment has been minimized.

Copy link
Author

commented Aug 7, 2017

  • View all issues without any filters (hide status = none) on all projects returns me a list of 67482 entries. The difference of 45 entries to the 67527 entries in bug-table is due to a disabled project. Page execution time is ~0,5 sec.

  • View all issues with an additional text-filter (hide status is still none) on all projects returns me a list of 163 entries with a page execution time of ~0,45 sec.

@atrol

This comment has been minimized.

Copy link
Member

commented Aug 7, 2017

View all issues with an additional text-filter (hide status is still none) on all projects returns me a list of 163 entries with a page execution time of ~0,45 sec.

Strange result, as I got what I expected on one of my test systems.
It's been about 6 times slower after the changes when searching by text.

Independant from that, there is a serious conceptual issue.
After the changes, you are able to search based on data where you are not allowed to view the data.

E.g. set Read Access of a custom field to access level manager.
Log in as a developer and search by text.
You will see issues in the list where you are not allowed to see the custom field.

@hloehnert

This comment has been minimized.

Copy link
Author

commented Aug 7, 2017

@atrol you convinced me.
Nevertheless I will keep it on my master branch, because the shown implementation is sufficient for us.

@hloehnert hloehnert closed this Aug 7, 2017
@hloehnert hloehnert deleted the hloehnert:#19302 branch Aug 7, 2017
@atrol

This comment has been minimized.

Copy link
Member

commented Aug 8, 2017

Nevertheless I will keep it on my master branch, because the shown implementation is sufficient for us.

Nice example for one of the advantages of Open Source.
Maybe it's also sufficient for other users,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.