Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPMailer to 6.0 #1410

Merged
merged 4 commits into from Nov 20, 2018

Conversation

Projects
None yet
4 participants
@dregad
Copy link
Member

commented Nov 17, 2018

Fixes #24990

@dregad

This comment has been minimized.

Copy link
Member Author

commented Nov 17, 2018

I performed quite a bit of testing locally, and did not notice any regressions.

@vboctor @atrol if you don't have any objections, I would suggest to merge this and apply at mantisbt.org ASAP, so we get some real-life testing before releasing 2.19.0. If that is not possible, then we should target 5.20.0, but in any case we should upgrade the library before end of 2018 due to end-of life of PHPMailer 5.2.

@dregad dregad requested review from vboctor and atrol Nov 17, 2018

@vboctor
Copy link
Member

left a comment

Ok to merge

@badfiles

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2018

I have been using phpmailer 6 in production since 6.0, with a very similar patch. It works pretty fine.

@dregad

This comment has been minimized.

Copy link
Member Author

commented Nov 19, 2018

Thanks for the feedback.
@atrol are you OK if I merge this today ?

@atrol

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

I started yesterday a few tests using $g_phpMailer_method = PHPMAILER_METHOD_MAIL; and didn't encounter any problems.

I don't have time at the moment to test other methods.
Feel free to merge today, so at least PHPMAILER_METHOD_SMTP could be tested on mantisbt.org.

dregad added some commits Nov 17, 2018

Setting PHPMailer::$LE is no longer necessary
Complete RFC standardisation on CRLF (\r\n) line breaks by default, but
it will automatically switch to \n when sending via mail() on UNIX.

See https://github.com/PHPMailer/PHPMailer/blob/master/UPGRADING.md

@dregad dregad force-pushed the dregad:phpmailer6 branch from a2460ea to c0638b7 Nov 20, 2018

@dregad dregad merged commit 8d5524d into mantisbt:master Nov 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dregad dregad deleted the dregad:phpmailer6 branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.